You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ross Allen <ro...@mesosphere.io> on 2013/12/14 00:38:34 UTC
Review Request 16264: Upgraded UI Bootstrap to 0.7.0, Angular to 1.2.3.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16264/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos-git
Description
-------
Upgraded UI Bootstrap to 0.7.0, Angular to 1.2.3.
* Re-implemented the dialog service since it was removed in 0.6.0.
Angular UI 0.5.0 fixed a major performance problem with the collapse
directive that was polling the scrollHeight of its element and forcing
unnecessary layouts.
Diffs
-----
src/Makefile.am 5f211a244f6f64aef4ababebdb542b40d6086b0b
src/webui/master/static/index.html 929cb0e9eca6825c2fe5b64a392045de6cfd8562
src/webui/master/static/js/angular-1.0.7.js a860c8594f4d1700a0f6672621e4389ac7863818
src/webui/master/static/js/angular-1.0.7.min.js 2b220688dfaa211beb682189ddf7d24336d4de45
src/webui/master/static/js/angular-1.2.3.min.js PRE-CREATION
src/webui/master/static/js/angular-route-1.2.3.js PRE-CREATION
src/webui/master/static/js/angular-route-1.2.3.min.js PRE-CREATION
src/webui/master/static/js/app.js 5c58b7e810cc9f8c10efc5ef991080dc9058c2bc
src/webui/master/static/js/controllers.js fb8ba88cd1301ea1bd0b7487e661e478e73242d7
src/webui/master/static/js/services.js 8fe3395e32423d229617706161e2e52a5debcec6
src/webui/master/static/js/ui-bootstrap-tpls-0.4.0.js 2e9eeb9842806492c95436f2f1e6b65a298fd5ff
src/webui/master/static/js/ui-bootstrap-tpls-0.4.0.min.js 009c43ac699939e1d9eeafeb70b5716e1fc1489d
src/webui/master/static/js/ui-bootstrap-tpls-0.7.0.min.js PRE-CREATION
Diff: https://reviews.apache.org/r/16264/diff/
Testing
-------
Thanks,
Ross Allen
Re: Review Request 16264: Upgraded UI Bootstrap to 0.7.0, Angular to 1.2.3.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16264/#review30391
-----------------------------------------------------------
Ship it!
Glad to see the upgrade!
- Benjamin Hindman
On Dec. 13, 2013, 11:40 p.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16264/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2013, 11:40 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Upgraded UI Bootstrap to 0.7.0, Angular to 1.2.3.
>
> * Re-implemented the dialog service since it was removed in 0.6.0.
>
> Angular UI 0.5.0 fixed a major performance problem with the collapse
> directive[1] that was polling the scrollHeight of its element and forcing
> unnecessary layouts.
>
> [1] https://github.com/angular-ui/bootstrap/commit/a72c635c7669933204c17bf85cfe3d4fc350c73a
>
>
> Diffs
> -----
>
> src/Makefile.am 5f211a244f6f64aef4ababebdb542b40d6086b0b
> src/webui/master/static/index.html 929cb0e9eca6825c2fe5b64a392045de6cfd8562
> src/webui/master/static/js/angular-1.0.7.js a860c8594f4d1700a0f6672621e4389ac7863818
> src/webui/master/static/js/angular-1.0.7.min.js 2b220688dfaa211beb682189ddf7d24336d4de45
> src/webui/master/static/js/angular-1.2.3.min.js PRE-CREATION
> src/webui/master/static/js/angular-route-1.2.3.js PRE-CREATION
> src/webui/master/static/js/angular-route-1.2.3.min.js PRE-CREATION
> src/webui/master/static/js/app.js 5c58b7e810cc9f8c10efc5ef991080dc9058c2bc
> src/webui/master/static/js/controllers.js fb8ba88cd1301ea1bd0b7487e661e478e73242d7
> src/webui/master/static/js/services.js 8fe3395e32423d229617706161e2e52a5debcec6
> src/webui/master/static/js/ui-bootstrap-tpls-0.4.0.js 2e9eeb9842806492c95436f2f1e6b65a298fd5ff
> src/webui/master/static/js/ui-bootstrap-tpls-0.4.0.min.js 009c43ac699939e1d9eeafeb70b5716e1fc1489d
> src/webui/master/static/js/ui-bootstrap-tpls-0.7.0.min.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16264/diff/
>
>
> Testing
> -------
>
> * Rendered each page of the UI in Firefox, Chrome, and Safari
> * Opened the log modals
> * Killed master to watch the master error modal
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 16264: Upgraded UI Bootstrap to 0.7.0, Angular to 1.2.3.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16264/#review30386
-----------------------------------------------------------
Ship it!
src/webui/master/static/js/controllers.js
<https://reviews.apache.org/r/16264/#comment58163>
Can you add a bit of background/motivation to this?
- Niklas Nielsen
On Dec. 13, 2013, 11:40 p.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16264/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2013, 11:40 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Upgraded UI Bootstrap to 0.7.0, Angular to 1.2.3.
>
> * Re-implemented the dialog service since it was removed in 0.6.0.
>
> Angular UI 0.5.0 fixed a major performance problem with the collapse
> directive[1] that was polling the scrollHeight of its element and forcing
> unnecessary layouts.
>
> [1] https://github.com/angular-ui/bootstrap/commit/a72c635c7669933204c17bf85cfe3d4fc350c73a
>
>
> Diffs
> -----
>
> src/Makefile.am 5f211a244f6f64aef4ababebdb542b40d6086b0b
> src/webui/master/static/index.html 929cb0e9eca6825c2fe5b64a392045de6cfd8562
> src/webui/master/static/js/angular-1.0.7.js a860c8594f4d1700a0f6672621e4389ac7863818
> src/webui/master/static/js/angular-1.0.7.min.js 2b220688dfaa211beb682189ddf7d24336d4de45
> src/webui/master/static/js/angular-1.2.3.min.js PRE-CREATION
> src/webui/master/static/js/angular-route-1.2.3.js PRE-CREATION
> src/webui/master/static/js/angular-route-1.2.3.min.js PRE-CREATION
> src/webui/master/static/js/app.js 5c58b7e810cc9f8c10efc5ef991080dc9058c2bc
> src/webui/master/static/js/controllers.js fb8ba88cd1301ea1bd0b7487e661e478e73242d7
> src/webui/master/static/js/services.js 8fe3395e32423d229617706161e2e52a5debcec6
> src/webui/master/static/js/ui-bootstrap-tpls-0.4.0.js 2e9eeb9842806492c95436f2f1e6b65a298fd5ff
> src/webui/master/static/js/ui-bootstrap-tpls-0.4.0.min.js 009c43ac699939e1d9eeafeb70b5716e1fc1489d
> src/webui/master/static/js/ui-bootstrap-tpls-0.7.0.min.js PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16264/diff/
>
>
> Testing
> -------
>
> * Rendered each page of the UI in Firefox, Chrome, and Safari
> * Opened the log modals
> * Killed master to watch the master error modal
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 16264: Upgraded UI Bootstrap to 0.7.0, Angular to 1.2.3.
Posted by Ross Allen <ro...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16264/
-----------------------------------------------------------
(Updated Dec. 13, 2013, 11:40 p.m.)
Review request for mesos.
Repository: mesos-git
Description (updated)
-------
Upgraded UI Bootstrap to 0.7.0, Angular to 1.2.3.
* Re-implemented the dialog service since it was removed in 0.6.0.
Angular UI 0.5.0 fixed a major performance problem with the collapse
directive[1] that was polling the scrollHeight of its element and forcing
unnecessary layouts.
[1] https://github.com/angular-ui/bootstrap/commit/a72c635c7669933204c17bf85cfe3d4fc350c73a
Diffs
-----
src/Makefile.am 5f211a244f6f64aef4ababebdb542b40d6086b0b
src/webui/master/static/index.html 929cb0e9eca6825c2fe5b64a392045de6cfd8562
src/webui/master/static/js/angular-1.0.7.js a860c8594f4d1700a0f6672621e4389ac7863818
src/webui/master/static/js/angular-1.0.7.min.js 2b220688dfaa211beb682189ddf7d24336d4de45
src/webui/master/static/js/angular-1.2.3.min.js PRE-CREATION
src/webui/master/static/js/angular-route-1.2.3.js PRE-CREATION
src/webui/master/static/js/angular-route-1.2.3.min.js PRE-CREATION
src/webui/master/static/js/app.js 5c58b7e810cc9f8c10efc5ef991080dc9058c2bc
src/webui/master/static/js/controllers.js fb8ba88cd1301ea1bd0b7487e661e478e73242d7
src/webui/master/static/js/services.js 8fe3395e32423d229617706161e2e52a5debcec6
src/webui/master/static/js/ui-bootstrap-tpls-0.4.0.js 2e9eeb9842806492c95436f2f1e6b65a298fd5ff
src/webui/master/static/js/ui-bootstrap-tpls-0.4.0.min.js 009c43ac699939e1d9eeafeb70b5716e1fc1489d
src/webui/master/static/js/ui-bootstrap-tpls-0.7.0.min.js PRE-CREATION
Diff: https://reviews.apache.org/r/16264/diff/
Testing
-------
* Rendered each page of the UI in Firefox, Chrome, and Safari
* Opened the log modals
* Killed master to watch the master error modal
Thanks,
Ross Allen
Re: Review Request 16264: Upgraded UI Bootstrap to 0.7.0, Angular to 1.2.3.
Posted by Ross Allen <ro...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16264/
-----------------------------------------------------------
(Updated Dec. 13, 2013, 11:39 p.m.)
Review request for mesos.
Repository: mesos-git
Description
-------
Upgraded UI Bootstrap to 0.7.0, Angular to 1.2.3.
* Re-implemented the dialog service since it was removed in 0.6.0.
Angular UI 0.5.0 fixed a major performance problem with the collapse
directive that was polling the scrollHeight of its element and forcing
unnecessary layouts.
Diffs
-----
src/Makefile.am 5f211a244f6f64aef4ababebdb542b40d6086b0b
src/webui/master/static/index.html 929cb0e9eca6825c2fe5b64a392045de6cfd8562
src/webui/master/static/js/angular-1.0.7.js a860c8594f4d1700a0f6672621e4389ac7863818
src/webui/master/static/js/angular-1.0.7.min.js 2b220688dfaa211beb682189ddf7d24336d4de45
src/webui/master/static/js/angular-1.2.3.min.js PRE-CREATION
src/webui/master/static/js/angular-route-1.2.3.js PRE-CREATION
src/webui/master/static/js/angular-route-1.2.3.min.js PRE-CREATION
src/webui/master/static/js/app.js 5c58b7e810cc9f8c10efc5ef991080dc9058c2bc
src/webui/master/static/js/controllers.js fb8ba88cd1301ea1bd0b7487e661e478e73242d7
src/webui/master/static/js/services.js 8fe3395e32423d229617706161e2e52a5debcec6
src/webui/master/static/js/ui-bootstrap-tpls-0.4.0.js 2e9eeb9842806492c95436f2f1e6b65a298fd5ff
src/webui/master/static/js/ui-bootstrap-tpls-0.4.0.min.js 009c43ac699939e1d9eeafeb70b5716e1fc1489d
src/webui/master/static/js/ui-bootstrap-tpls-0.7.0.min.js PRE-CREATION
Diff: https://reviews.apache.org/r/16264/diff/
Testing (updated)
-------
* Rendered each page of the UI in Firefox, Chrome, and Safari
* Opened the log modals
* Killed master to watch the master error modal
Thanks,
Ross Allen