You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/10/27 17:39:49 UTC
[GitHub] [cordova-plugin-camera] jcesarmobile opened a new pull request #685: fix(ios): correctly append exif on iOS 14
jcesarmobile opened a new pull request #685:
URL: https://github.com/apache/cordova-plugin-camera/pull/685
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
ios
### Motivation and Context
on iOS 14 if using `<preference name="CameraUsesGeolocation" value="true" />` when trying to append the gps data to the exif the image gets corrupted
closes #674
### Description
<!-- Describe your changes in detail -->
### Testing
Used https://github.com/guilhermefarias/cordova-exif plugin to check the exif of the image after capturing on the provided sample app https://github.com/R4yYx/IOSSampleAPP
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] jcesarmobile merged pull request #685: fix(ios): correctly append exif on iOS 14
Posted by GitBox <gi...@apache.org>.
jcesarmobile merged pull request #685:
URL: https://github.com/apache/cordova-plugin-camera/pull/685
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-camera] jcesarmobile commented on pull request #685: fix(ios): correctly append exif on iOS 14
Posted by GitBox <gi...@apache.org>.
jcesarmobile commented on pull request #685:
URL: https://github.com/apache/cordova-plugin-camera/pull/685#issuecomment-717947052
No, but debugging I noticed the data became null/empty on the second `CGImageSourceCreateWithData` call, while calling it only once didn't, so I used a copy of the data to create the source and the original data for the destination.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org