You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/12/30 15:53:10 UTC

[GitHub] [doris] morningman opened a new pull request, #15542: [fix](create-table) wrong judgement about partition column type

morningman opened a new pull request, #15542:
URL: https://github.com/apache/doris/pull/15542

   # Proposed changes
   
   Issue Number: close #xxx
   
   ## Problem summary
   
   The following stmt should be success, but return error: `complex type cannt be partition column:ARRAY<VARCHAR(64)>`
   
   ```
   create table test_array( 
   task_insert_time BIGINT NOT NULL DEFAULT "0" COMMENT "" , 
   task_project ARRAY<VARCHAR(64)>  DEFAULT NULL COMMENT "" ,
   route_key DATEV2 NOT NULL COMMENT "range分区键"
   ) 
   DUPLICATE KEY(`task_insert_time`)  
    COMMENT ""
   PARTITION BY RANGE(route_key) 
   (PARTITION `p202209` VALUES LESS THAN ("2022-10-01"),
   PARTITION `p202210` VALUES LESS THAN ("2022-11-01"),
   PARTITION `p202211` VALUES LESS THAN ("2022-12-01")) 
   DISTRIBUTED BY HASH(`task_insert_time` ) BUCKETS 32 
   PROPERTIES
   (
       "replication_num" = "1",    
       "light_schema_change" = "true"    
   );
   ```
   
   This PR fix this
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: 
       - [ ] Yes
       - [ ] No
       - [ ] I don't know
   2. Has unit tests been added:
       - [ ] Yes
       - [ ] No
       - [ ] No Need
   3. Has document been added or modified:
       - [ ] Yes
       - [ ] No
       - [ ] No Need
   4. Does it need to update dependencies:
       - [ ] Yes
       - [ ] No
   5. Are there any changes that cannot be rolled back:
       - [ ] Yes (If Yes, please explain WHY)
       - [ ] No
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] hello-stephen commented on pull request #15542: [fix](create-table) wrong judgement about partition column type

Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #15542:
URL: https://github.com/apache/doris/pull/15542#issuecomment-1368013339

   TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 36.85 seconds
    load time: 645 seconds
    storage size: 17123703761 Bytes
    https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221230170359_clickbench_pr_72123.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #15542: [fix](create-table) wrong judgement about partition column type

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15542:
URL: https://github.com/apache/doris/pull/15542#issuecomment-1368164510

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #15542: [fix](create-table) wrong judgement about partition column type

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15542:
URL: https://github.com/apache/doris/pull/15542#issuecomment-1368164514

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] morningman merged pull request #15542: [fix](create-table) wrong judgement about partition column type

Posted by GitBox <gi...@apache.org>.
morningman merged PR #15542:
URL: https://github.com/apache/doris/pull/15542


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org