You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/07/20 14:46:35 UTC
[GitHub] [dubbo-go] seasidesky opened a new issue #666: hystrix filter initHystrixConfigProvider incorrect
seasidesky opened a new issue #666:
URL: https://github.com/apache/dubbo-go/issues/666
<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks!
-->
**What happened**:
https://github.com/apache/dubbo-go/blob/master/filter/filter_impl/hystrix_filter.go#L237
```
filterConfig := config.GetConsumerConfig().FilterConf.(map[interface{}]interface{})[HYSTRIX]
```
there is a misuse of config.GetConsumerConfig()
**What you expected to happen**:
https://github.com/apache/dubbo-go/blob/master/filter/filter_impl/hystrix_filter.go#L237
is expected to like this
```
filterConfig := config.GetProviderConfig().FilterConf.(map[interface{}]interface{})[HYSTRIX]
```
**How to reproduce it (as minimally and precisely as possible)**:
**Anything else we need to know?**:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] hxmhlt commented on issue #666: hystrix filter initHystrixConfigProvider incorrect
Posted by GitBox <gi...@apache.org>.
hxmhlt commented on issue #666:
URL: https://github.com/apache/dubbo-go/issues/666#issuecomment-661581036
Hi，Hystrix is a fuse solution. As we know, fuses are defined on the consumer side, because fusing is an active protection from the perspective of the client.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] zouyx commented on issue #666: hystrix filter initHystrixConfigProvider incorrect
Posted by GitBox <gi...@apache.org>.
zouyx commented on issue #666:
URL: https://github.com/apache/dubbo-go/issues/666#issuecomment-681316443
the same to #710
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] zouyx closed issue #666: hystrix filter initHystrixConfigProvider incorrect
Posted by GitBox <gi...@apache.org>.
zouyx closed issue #666:
URL: https://github.com/apache/dubbo-go/issues/666
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] seasidesky commented on issue #666: hystrix filter initHystrixConfigProvider incorrect
Posted by GitBox <gi...@apache.org>.
seasidesky commented on issue #666:
URL: https://github.com/apache/dubbo-go/issues/666#issuecomment-661659636
I got it, but https://github.com/apache/dubbo-go/blob/master/filter/filter_impl/hystrix_filter.go#L234 and https://github.com/apache/dubbo-go/blob/master/filter/filter_impl/hystrix_filter.go#L237 is a little confusing.
as https://github.com/apache/dubbo-go/blob/master/filter/filter_impl/hystrix_filter.go#L237
```
if config.GetProviderConfig().FilterConf == nil
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] YGrylls commented on issue #666: hystrix filter initHystrixConfigProvider incorrect
Posted by GitBox <gi...@apache.org>.
YGrylls commented on issue #666:
URL: https://github.com/apache/dubbo-go/issues/666#issuecomment-681316770
@seasidesky Thank you for mention this. Yes, this is a known bug. Will be fixed this weekend and included in the next release at about mid September. #710
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] seasidesky edited a comment on issue #666: hystrix filter initHystrixConfigProvider incorrect
Posted by GitBox <gi...@apache.org>.
seasidesky edited a comment on issue #666:
URL: https://github.com/apache/dubbo-go/issues/666#issuecomment-661659636
I got it, but https://github.com/apache/dubbo-go/blob/master/filter/filter_impl/hystrix_filter.go#L234 and https://github.com/apache/dubbo-go/blob/master/filter/filter_impl/hystrix_filter.go#L237 is a little confusing.
as https://github.com/apache/dubbo-go/blob/master/filter/filter_impl/hystrix_filter.go#L234
```
if config.GetProviderConfig().FilterConf == nil
```
while https://github.com/apache/dubbo-go/blob/master/filter/filter_impl/hystrix_filter.go#L237
```
filterConfig := config.GetConsumerConfig().FilterConf.(map[interface{}]interface{})[HYSTRIX]]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org