You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Ryan Ernst (JIRA)" <ji...@apache.org> on 2015/04/29 02:44:06 UTC
[jira] [Comment Edited] (LUCENE-6213) Add test for
IndexFormatTooOldException if a commit has a 3.x segment
[ https://issues.apache.org/jira/browse/LUCENE-6213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14518460#comment-14518460 ]
Ryan Ernst edited comment on LUCENE-6213 at 4/29/15 12:43 AM:
--------------------------------------------------------------
[~hossman] We already check unsupported indexes are tested. I do think we should check for this, but only once a version is released. For example, we didn't fail expecting a bwc test for 5.0.0 until that was actually available (we list apache archives of lucene release to find all the versions we expect). In this case, we probably just need some extra logic for a major release. Eg. For M.0.0, expect a test index "(M)x-with-(M-1)x-segments". I think this is essentially what you were saying?
We should also have this easily created with addBackcompatIndexes.py, so that when it runs on a major release it also creates one of these mixed indexes. I created LUCENE-6457 to track this.
was (Author: rjernst):
[~hossman] We already check unsupported indexes are tested. I do think we should check for this, but only once a version is released. For example, we didn't fail expecting a bwc test for 5.0.0 until that was actually available (we list apache archives of lucene release to find all the versions we expect). In this case, we probably just need some extra logic for a major release. Eg. For M.0.0, expect a test index "{M}x-with-{M-1}x-segments". I think this is essentially what you were saying?
We should also have this easily created with addBackcompatIndexes.py, so that when it runs on a major release it also creates one of these mixed indexes. I created LUCENE-6457 to track this.
> Add test for IndexFormatTooOldException if a commit has a 3.x segment
> ---------------------------------------------------------------------
>
> Key: LUCENE-6213
> URL: https://issues.apache.org/jira/browse/LUCENE-6213
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Robert Muir
> Assignee: Ryan Ernst
> Attachments: LUCENE-6213.patch, LUCENE-6213.patch, LUCENE-6213.patch, unsupported.4x-with-3x-segments.zip
>
>
> We should add a 4.x index (4.x commit) with some 3.x segment(s) to our backwards tests.
> I don't think we throw IndexFormatTooOldException correctly in this case. I think instead the user will get a confusing SPI error about a missing codec "Lucene3x".
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org