[GitHub] [incubator-nuttx-apps] povauboin commented on a change in pull request #338: fsutils/mkfatfs: use DMA memory for mkfatfs when needed

[GitBox <gi...@apache.org>]

povauboin commented on a change in pull request #338:
URL: https://github.com/apache/incubator-nuttx-apps/pull/338#discussion_r458757404



##########
File path: fsutils/mkfatfs/mkfatfs.c
##########
@@ -337,7 +338,11 @@ int mkfatfs(FAR const char *pathname, FAR struct fat_format_s *fmt)
 
   /* Allocate a buffer that will be working sector memory */
 
+#ifdef CONFIG_FAT_DMAMEMORY
+  var.fv_sect = (FAR uint8_t *)fat_dma_alloc(var.fv_sectorsize);
+#else

Review comment:
       Ah, this is why you removed it while moving to apps/ then.
   
   But fat_dma_alloc is defined in https://github.com/apache/incubator-nuttx/blob/master/include/nuttx/fs/fat.h#L115
   And there are many other apps that use something like #include <nuttx/*.h>
   
   Anyway what do you suggest ? Is there a fix or I just remove the PR ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org