You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/01/05 09:36:24 UTC

[GitHub] [dolphinscheduler] devosend commented on a change in pull request #7818: [python] Add checker pd attr param and fix switch example

devosend commented on a change in pull request #7818:
URL: https://github.com/apache/dolphinscheduler/pull/7818#discussion_r778671861



##########
File path: dolphinscheduler-python/pydolphinscheduler/src/pydolphinscheduler/core/process_definition.py
##########
@@ -189,6 +190,21 @@ def end_time(self, val) -> None:
         """Set attribute end_time."""
         self._end_time = val
 
+    @property
+    def param_json(self) -> Optional[List[Dict]]:
+        """Return param json base on self.param."""
+        if self.param is None or not self.param:

Review comment:
       Aren't these two judgment conditions the same?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org