You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/12/29 06:17:36 UTC
[GitHub] [dubbo-samples] bq-xiao opened a new pull request #192: add sample docker test case configuration and refactor maven dependen…
bq-xiao opened a new pull request #192:
URL: https://github.com/apache/dubbo-samples/pull/192
Changed below:
+ add dubbo-samples-docker test case configuration file
+ refactor maven dependencies use dependencyManagement
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] bq-xiao commented on a change in pull request #192: add sample docker test case configuration and refactor maven dependen…
Posted by GitBox <gi...@apache.org>.
bq-xiao commented on a change in pull request #192:
URL: https://github.com/apache/dubbo-samples/pull/192#discussion_r549615233
##########
File path: dubbo-samples-docker/pom.xml
##########
@@ -42,18 +42,40 @@
<zookeeper.port>2181</zookeeper.port>
Review comment:
OK，已删除未使用的properties
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] chickenlj merged pull request #192: add sample docker test case configuration and refactor maven dependen…
Posted by GitBox <gi...@apache.org>.
chickenlj merged pull request #192:
URL: https://github.com/apache/dubbo-samples/pull/192
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] bq-xiao commented on a change in pull request #192: add sample docker test case configuration and refactor maven dependen…
Posted by GitBox <gi...@apache.org>.
bq-xiao commented on a change in pull request #192:
URL: https://github.com/apache/dubbo-samples/pull/192#discussion_r549595573
##########
File path: dubbo-samples-docker/pom.xml
##########
@@ -42,19 +42,46 @@
<zookeeper.port>2181</zookeeper.port>
<main-class>org.apache.dubbo.samples.docker.DubboApplication</main-class>
</properties>
-
+ <dependencyManagement>
+ <dependencies>
+ <dependency>
+ <!-- Import dependency management from Spring Boot -->
+ <groupId>org.springframework.boot</groupId>
+ <artifactId>spring-boot-dependencies</artifactId>
+ <version>${spring.boot.version}</version>
+ <type>pom</type>
+ <scope>import</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.dubbo</groupId>
+ <artifactId>dubbo-bom</artifactId>
+ <version>${dubbo.version}</version>
+ <type>pom</type>
+ <scope>import</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.dubbo</groupId>
+ <artifactId>dubbo-dependencies-zookeeper</artifactId>
+ <version>${dubbo.version}</version>
+ <type>pom</type>
+ <scope>import</scope>
Review comment:
OK，已修改
##########
File path: dubbo-samples-docker/pom.xml
##########
@@ -89,23 +114,6 @@
<id>dubbo-integration-test</id>
Review comment:
已修改
##########
File path: dubbo-samples-docker/pom.xml
##########
@@ -42,19 +42,46 @@
<zookeeper.port>2181</zookeeper.port>
<main-class>org.apache.dubbo.samples.docker.DubboApplication</main-class>
</properties>
-
+ <dependencyManagement>
+ <dependencies>
+ <dependency>
+ <!-- Import dependency management from Spring Boot -->
+ <groupId>org.springframework.boot</groupId>
+ <artifactId>spring-boot-dependencies</artifactId>
+ <version>${spring.boot.version}</version>
+ <type>pom</type>
+ <scope>import</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.dubbo</groupId>
+ <artifactId>dubbo-bom</artifactId>
+ <version>${dubbo.version}</version>
+ <type>pom</type>
+ <scope>import</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.dubbo</groupId>
+ <artifactId>dubbo-dependencies-zookeeper</artifactId>
+ <version>${dubbo.version}</version>
+ <type>pom</type>
+ <scope>import</scope>
+ </dependency>
+ </dependencies>
+ </dependencyManagement>
<dependencies>
<dependency>
<groupId>org.apache.dubbo</groupId>
<artifactId>dubbo</artifactId>
- <version>${dubbo.version}</version>
</dependency>
<dependency>
- <groupId>org.apache.dubbo</groupId>
- <artifactId>dubbo-dependencies-zookeeper</artifactId>
- <version>${dubbo.version}</version>
- <type>pom</type>
+ <groupId>org.apache.curator</groupId>
Review comment:
已修改
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] kylixs commented on a change in pull request #192: add sample docker test case configuration and refactor maven dependen…
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #192:
URL: https://github.com/apache/dubbo-samples/pull/192#discussion_r549591914
##########
File path: dubbo-samples-docker/pom.xml
##########
@@ -89,23 +114,6 @@
<id>dubbo-integration-test</id>
Review comment:
把整个dubbo-integration-test profile删除掉
##########
File path: dubbo-samples-docker/pom.xml
##########
@@ -42,19 +42,46 @@
<zookeeper.port>2181</zookeeper.port>
<main-class>org.apache.dubbo.samples.docker.DubboApplication</main-class>
</properties>
-
+ <dependencyManagement>
+ <dependencies>
+ <dependency>
+ <!-- Import dependency management from Spring Boot -->
+ <groupId>org.springframework.boot</groupId>
+ <artifactId>spring-boot-dependencies</artifactId>
+ <version>${spring.boot.version}</version>
+ <type>pom</type>
+ <scope>import</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.dubbo</groupId>
+ <artifactId>dubbo-bom</artifactId>
+ <version>${dubbo.version}</version>
+ <type>pom</type>
+ <scope>import</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.dubbo</groupId>
+ <artifactId>dubbo-dependencies-zookeeper</artifactId>
+ <version>${dubbo.version}</version>
+ <type>pom</type>
+ <scope>import</scope>
Review comment:
dubbo-dependencies-zookeeper 不是管理依赖的bom，删除` <scope>import</scope>`
##########
File path: dubbo-samples-docker/pom.xml
##########
@@ -42,19 +42,46 @@
<zookeeper.port>2181</zookeeper.port>
<main-class>org.apache.dubbo.samples.docker.DubboApplication</main-class>
</properties>
-
+ <dependencyManagement>
+ <dependencies>
+ <dependency>
+ <!-- Import dependency management from Spring Boot -->
+ <groupId>org.springframework.boot</groupId>
+ <artifactId>spring-boot-dependencies</artifactId>
+ <version>${spring.boot.version}</version>
+ <type>pom</type>
+ <scope>import</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.dubbo</groupId>
+ <artifactId>dubbo-bom</artifactId>
+ <version>${dubbo.version}</version>
+ <type>pom</type>
+ <scope>import</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.dubbo</groupId>
+ <artifactId>dubbo-dependencies-zookeeper</artifactId>
+ <version>${dubbo.version}</version>
+ <type>pom</type>
+ <scope>import</scope>
+ </dependency>
+ </dependencies>
+ </dependencyManagement>
<dependencies>
<dependency>
<groupId>org.apache.dubbo</groupId>
<artifactId>dubbo</artifactId>
- <version>${dubbo.version}</version>
</dependency>
<dependency>
- <groupId>org.apache.dubbo</groupId>
- <artifactId>dubbo-dependencies-zookeeper</artifactId>
- <version>${dubbo.version}</version>
- <type>pom</type>
+ <groupId>org.apache.curator</groupId>
Review comment:
原来的dubbo-dependencies-zookeeper是正确的，只需要删除version，因为上面管理了
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] kylixs commented on a change in pull request #192: add sample docker test case configuration and refactor maven dependen…
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #192:
URL: https://github.com/apache/dubbo-samples/pull/192#discussion_r549612660
##########
File path: dubbo-samples-docker/pom.xml
##########
@@ -42,18 +42,40 @@
<zookeeper.port>2181</zookeeper.port>
Review comment:
请删除pom中不需要的属性，如docker-maven-plugin.version/jib-maven-plugin.version/maven-failsafe-plugin.version/image.name/java-image.name/dubbo.port/zookeeper.port
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org