You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Aaron Wood <aa...@verizon.com> on 2016/12/21 22:50:11 UTC
Review Request 54953: Set -pie conditionally on whether hardening is
enabled or not.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54953/
-----------------------------------------------------------
Review request for mesos and Michael Park.
Bugs: MESOS-6830
https://issues.apache.org/jira/browse/MESOS-6830
Repository: mesos
Description
-------
The gold linker complains about using -pie without -fPIC which causes the build to fail right before the end. This makes sure both -pie and -fPIC/-fPIE are enabled/disabled based on the setting for enabling/disabling hardening.
Diffs
-----
src/Makefile.am abcf7eed7
Diff: https://reviews.apache.org/r/54953/diff/
Testing
-------
../configure --disable-python --disable-java && make
../configure --disable-python --disable-java --disable-hardening && make
Thanks,
Aaron Wood
Re: Review Request 54953: Set -pie conditionally on whether hardening
is enabled or not.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54953/#review159877
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On Dec. 21, 2016, 2:50 p.m., Aaron Wood wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54953/
> -----------------------------------------------------------
>
> (Updated Dec. 21, 2016, 2:50 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Bugs: MESOS-6830
> https://issues.apache.org/jira/browse/MESOS-6830
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The gold linker complains about using -pie without -fPIC which causes the build to fail right before the end. This makes sure both -pie and -fPIC/-fPIE are enabled/disabled based on the setting for enabling/disabling hardening.
>
>
> Diffs
> -----
>
> src/Makefile.am abcf7eed7
>
> Diff: https://reviews.apache.org/r/54953/diff/
>
>
> Testing
> -------
>
> ../configure --disable-python --disable-java && make
> ../configure --disable-python --disable-java --disable-hardening && make
>
>
> Thanks,
>
> Aaron Wood
>
>
Re: Review Request 54953: Set -pie conditionally on whether hardening
is enabled or not.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54953/#review159883
-----------------------------------------------------------
src/Makefile.am (line 88)
<https://reviews.apache.org/r/54953/#comment230934>
Should we remove this rather than defining it as empty here? I'm seeing the following warning during `./bootstrap`:
```
src/Makefile.am:111: warning: AM_LDFLAGS was already defined in condition TRUE, which includes condition ENABLE_HARDENING ...
src/Makefile.am:88: ... 'AM_LDFLAGS' previously defined here
```
- Michael Park
On Dec. 21, 2016, 2:50 p.m., Aaron Wood wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54953/
> -----------------------------------------------------------
>
> (Updated Dec. 21, 2016, 2:50 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Bugs: MESOS-6830
> https://issues.apache.org/jira/browse/MESOS-6830
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The gold linker complains about using -pie without -fPIC which causes the build to fail right before the end. This makes sure both -pie and -fPIC/-fPIE are enabled/disabled based on the setting for enabling/disabling hardening.
>
>
> Diffs
> -----
>
> src/Makefile.am abcf7eed7
>
> Diff: https://reviews.apache.org/r/54953/diff/
>
>
> Testing
> -------
>
> ../configure --disable-python --disable-java && make
> ../configure --disable-python --disable-java --disable-hardening && make
>
>
> Thanks,
>
> Aaron Wood
>
>
Re: Review Request 54953: Set -pie conditionally on whether hardening
is enabled or not.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54953/#review159872
-----------------------------------------------------------
Ship it!
Ship It!
- James Peach
On Dec. 21, 2016, 10:50 p.m., Aaron Wood wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54953/
> -----------------------------------------------------------
>
> (Updated Dec. 21, 2016, 10:50 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Bugs: MESOS-6830
> https://issues.apache.org/jira/browse/MESOS-6830
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The gold linker complains about using -pie without -fPIC which causes the build to fail right before the end. This makes sure both -pie and -fPIC/-fPIE are enabled/disabled based on the setting for enabling/disabling hardening.
>
>
> Diffs
> -----
>
> src/Makefile.am abcf7eed7
>
> Diff: https://reviews.apache.org/r/54953/diff/
>
>
> Testing
> -------
>
> ../configure --disable-python --disable-java && make
> ../configure --disable-python --disable-java --disable-hardening && make
>
>
> Thanks,
>
> Aaron Wood
>
>
Re: Review Request 54953: Set -pie conditionally on whether hardening
is enabled or not.
Posted by Aaron Wood <aa...@verizon.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54953/
-----------------------------------------------------------
(Updated Dec. 22, 2016, 12:30 a.m.)
Review request for mesos and Michael Park.
Changes
-------
Add on to `AM_LDFLAGS`.
Bugs: MESOS-6830
https://issues.apache.org/jira/browse/MESOS-6830
Repository: mesos
Description
-------
The gold linker complains about using -pie without -fPIC which causes the build to fail right before the end. This makes sure both -pie and -fPIC/-fPIE are enabled/disabled based on the setting for enabling/disabling hardening.
Diffs (updated)
-----
src/Makefile.am abcf7eed7
Diff: https://reviews.apache.org/r/54953/diff/
Testing
-------
../configure --disable-python --disable-java && make
../configure --disable-python --disable-java --disable-hardening && make
Thanks,
Aaron Wood
Re: Review Request 54953: Set -pie conditionally on whether hardening
is enabled or not.
Posted by Aaron Wood <aa...@verizon.com>.
> On Dec. 21, 2016, 11:57 p.m., Michael Park wrote:
> > src/Makefile.am, line 112
> > <https://reviews.apache.org/r/54953/diff/1/?file=1590647#file1590647line112>
> >
> > Actually, I think we want to `+=` here instead?
You're right, good catch.
- Aaron
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54953/#review159886
-----------------------------------------------------------
On Dec. 21, 2016, 10:50 p.m., Aaron Wood wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54953/
> -----------------------------------------------------------
>
> (Updated Dec. 21, 2016, 10:50 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Bugs: MESOS-6830
> https://issues.apache.org/jira/browse/MESOS-6830
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The gold linker complains about using -pie without -fPIC which causes the build to fail right before the end. This makes sure both -pie and -fPIC/-fPIE are enabled/disabled based on the setting for enabling/disabling hardening.
>
>
> Diffs
> -----
>
> src/Makefile.am abcf7eed7
>
> Diff: https://reviews.apache.org/r/54953/diff/
>
>
> Testing
> -------
>
> ../configure --disable-python --disable-java && make
> ../configure --disable-python --disable-java --disable-hardening && make
>
>
> Thanks,
>
> Aaron Wood
>
>
Re: Review Request 54953: Set -pie conditionally on whether hardening
is enabled or not.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54953/#review159886
-----------------------------------------------------------
src/Makefile.am (line 111)
<https://reviews.apache.org/r/54953/#comment230937>
Actually, I think we want to `+=` here instead?
- Michael Park
On Dec. 21, 2016, 2:50 p.m., Aaron Wood wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54953/
> -----------------------------------------------------------
>
> (Updated Dec. 21, 2016, 2:50 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Bugs: MESOS-6830
> https://issues.apache.org/jira/browse/MESOS-6830
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The gold linker complains about using -pie without -fPIC which causes the build to fail right before the end. This makes sure both -pie and -fPIC/-fPIE are enabled/disabled based on the setting for enabling/disabling hardening.
>
>
> Diffs
> -----
>
> src/Makefile.am abcf7eed7
>
> Diff: https://reviews.apache.org/r/54953/diff/
>
>
> Testing
> -------
>
> ../configure --disable-python --disable-java && make
> ../configure --disable-python --disable-java --disable-hardening && make
>
>
> Thanks,
>
> Aaron Wood
>
>