svn commit: r1838483 - /httpd/test/framework/trunk/c-modules/nntp_like/mod_nntp_like.c

[ja...@apache.org]

Author: jailletc36
Date: Mon Aug 20 20:03:05 2018
New Revision: 1838483

URL: http://svn.apache.org/viewvc?rev=1838483&view=rev
Log:
This is harmless, but cppcheck is right to warn about the spurious ')' position.

The only difference is the value of 'rv' after the test in case of error, but it is not used anymore, so we don't really care.

Modified:
    httpd/test/framework/trunk/c-modules/nntp_like/mod_nntp_like.c

Modified: httpd/test/framework/trunk/c-modules/nntp_like/mod_nntp_like.c
URL: http://svn.apache.org/viewvc/httpd/test/framework/trunk/c-modules/nntp_like/mod_nntp_like.c?rev=1838483&r1=1838482&r2=1838483&view=diff
==============================================================================
--- httpd/test/framework/trunk/c-modules/nntp_like/mod_nntp_like.c (original)
+++ httpd/test/framework/trunk/c-modules/nntp_like/mod_nntp_like.c Mon Aug 20 20:03:05 2018
@@ -139,8 +139,8 @@ static int nntp_like_process_connection(
 
         if ((rv = ap_get_brigade(c->input_filters, bb,
                                  AP_MODE_GETLINE,
-                                 APR_BLOCK_READ, 0) != APR_SUCCESS || 
-             APR_BRIGADE_EMPTY(bb)))
+                                 APR_BLOCK_READ, 0)) != APR_SUCCESS || 
+             APR_BRIGADE_EMPTY(bb))
         {
             apr_brigade_destroy(bb);
             break;