[GitHub] [skywalking-nginx-lua] wu-sheng commented on a change in pull request #68: fix: missing `constants` in the rockspsec

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #68:
URL: https://github.com/apache/skywalking-nginx-lua/pull/68#discussion_r585302006



##########
File path: rockspec/skywalking-nginx-lua-0.4-1.rockspec
##########
@@ -1,5 +1,5 @@
 package = "skywalking-nginx-lua"
-version = "0.4-0"
+version = "0.4-1"
 source = {
    url = "git://github.com/apache/skywalking-nginx-lua",
    branch = "v0.4.0",

Review comment:
       I think we need to change the tag and run another release vote call, due to the rockspec files have been managed and included by the source tar, which is changed, meaning this is another version.
   ```suggestion
      branch = "v0.4.1",
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org