You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2024/01/26 05:24:05 UTC

[PR] [SPARK-46871][PS][TESTS] Clean up the imports in `pyspark.pandas.tests.computation.*` [spark]

zhengruifeng opened a new pull request, #44895:
URL: https://github.com/apache/spark/pull/44895

   ### What changes were proposed in this pull request?
   Clean up the imports in `pyspark.pandas.tests.computation.*`
   
   
   ### Why are the changes needed?
   1, remove unused imports;
   2, define the test dataset in the vanilla side, so that won't need to define it again in the parity tests;
   
   
   ### Does this PR introduce _any_ user-facing change?
   no, test-only
   
   ### How was this patch tested?
   ci
   
   ### Was this patch authored or co-authored using generative AI tooling?
   no


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-46871][PS][TESTS] Clean up the imports in `pyspark.pandas.tests.computation.*` [spark]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #44895: [SPARK-46871][PS][TESTS] Clean up the imports in `pyspark.pandas.tests.computation.*`
URL: https://github.com/apache/spark/pull/44895


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-46871][PS][TESTS] Clean up the imports in `pyspark.pandas.tests.computation.*` [spark]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #44895:
URL: https://github.com/apache/spark/pull/44895#issuecomment-1911563148

   Merged to master for Apache Spark 4.0.0. Thank you for this clean up, @zhengruifeng .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-46871][PS][TESTS] Clean up the imports in `pyspark.pandas.tests.computation.*` [spark]

Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #44895:
URL: https://github.com/apache/spark/pull/44895#issuecomment-1911586727

   thanks @dongjoon-hyun 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org