You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/12 18:10:56 UTC
[GitHub] [apisix] jbampton opened a new pull request #3027: chore: spelling
jbampton opened a new pull request #3027:
URL: https://github.com/apache/apisix/pull/3027
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
* [ ] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tokers commented on a change in pull request #3027: chore: spelling
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #3027:
URL: https://github.com/apache/apisix/pull/3027#discussion_r541819314
##########
File path: t/node/invalid-upstream.t
##########
@@ -47,7 +47,7 @@ GET /t
--- grep_error_log eval
qr/\[error\].*/
--- grep_error_log_out eval
-qr{invalid item data of \[/apisix/upstreams/1\], val: mexxxxxxxxxxxxxxx, it shoud be a object}
+qr{invalid item data of \[/apisix/upstreams/1\], val: mexxxxxxxxxxxxxxx, it should be a object}
Review comment:
Ditto
##########
File path: t/node/invalid-upstream.t
##########
@@ -63,7 +63,7 @@ GET /not_found
--- grep_error_log eval
qr/\[error\].*/
--- grep_error_log_out eval
-qr{invalid item data of \[/apisix/upstreams/1\], val: mexxxxxxxxxxxxxxx, it shoud be a object}
+qr{invalid item data of \[/apisix/upstreams/1\], val: mexxxxxxxxxxxxxxx, it should be a object}
Review comment:
Ditto
##########
File path: t/node/invalid-service.t
##########
@@ -64,7 +64,7 @@ GET /not_found
--- grep_error_log eval
qr/\[error\].*/
--- grep_error_log_out eval
-qr{invalid item data of \[/apisix/services/1\], val: mexxxxxxxxxxxxxxx, it shoud be a object}
+qr{invalid item data of \[/apisix/services/1\], val: mexxxxxxxxxxxxxxx, it should be a object}
Review comment:
It should be an object.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] moonming merged pull request #3027: chore: spelling
Posted by GitBox <gi...@apache.org>.
moonming merged pull request #3027:
URL: https://github.com/apache/apisix/pull/3027
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org