You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/08/24 23:55:01 UTC
[GitHub] [iceberg] aokolnychyi commented on a change in pull request #1374: Fix FileHandle Leak in BaseDataReader for MetadataFiles
aokolnychyi commented on a change in pull request #1374:
URL: https://github.com/apache/iceberg/pull/1374#discussion_r475976608
##########
File path: api/src/test/java/org/apache/iceberg/io/TestCloseableIterable.java
##########
@@ -28,6 +29,36 @@
public class TestCloseableIterable {
+ @Test
+ public void testFilterManuallyClosable() throws IOException {
+ TestableCloseableIterable iterable = new TestableCloseableIterable();
+ TestableCloseableIterable.TestableCloseableIterator iterator =
Review comment:
nit: can we import `TestableCloseableIterator` and fit on one line?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org