[GitHub] [solr] dsmiley commented on pull request #1211: SOLR-8975: Use Builder Pattern with Solr Clients

[GitBox <gi...@apache.org>]

dsmiley commented on PR #1211:
URL: https://github.com/apache/solr/pull/1211#issuecomment-1338673045

   It would be nice if the scope of this PR could be clearer -- like the setters (... specify here ...) on all SolrClients are now supported on the Builder of these SolrClients, and their setters are deprecated.  Then stick to this scope and do other things in other PRs.  Then you needn't list how some specific clients changed; it's kind of a needless detail I suppose.  This might not lead to an actual change on this PR; the test changes are fine?  My goal is communicating clearly to users (and us) what happened here).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org