You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@karaf.apache.org by "Guillaume Nodet (JIRA)" <ji...@apache.org> on 2010/07/21 12:46:49 UTC
[jira] Created: (KARAF-133) NPE when installing a bundle with a
MANIFEST.MF not in the first entry of the zip
NPE when installing a bundle with a MANIFEST.MF not in the first entry of the zip
---------------------------------------------------------------------------------
Key: KARAF-133
URL: https://issues.apache.org/jira/browse/KARAF-133
Project: Karaf
Issue Type: Bug
Reporter: Guillaume Nodet
I don't think we should necesseraly support those jars, as it would force us to download the whole jar, but we should at least throw a meaningful exception
{code}
java.lang.NullPointerException
at org.apache.karaf.features.internal.FeaturesServiceImpl.installBundleIfNeeded(FeaturesServiceImpl.java:560)
at org.apache.karaf.features.internal.FeaturesServiceImpl.doInstallFeature(FeaturesServiceImpl.java:401)
at org.apache.karaf.features.internal.FeaturesServiceImpl.installFeatures(FeaturesServiceImpl.java:246)
at org.apache.karaf.features.internal.FeaturesServiceImpl.installFeature(FeaturesServiceImpl.java:235)
at org.apache.karaf.features.internal.FeaturesServiceImpl.installFeature(FeaturesServiceImpl.java:231)
at org.apache.karaf.features.command.InstallFeatureCommand.doExecute(InstallFeatureCommand.java:51)
at org.apache.karaf.features.command.FeaturesCommandSupport.doExecute(FeaturesCommandSupport.java:39)
at org.apache.karaf.shell.console.OsgiCommandSupport.execute(OsgiCommandSupport.java:41)
at org.apache.felix.gogo.commands.basic.AbstractCommand.execute(AbstractCommand.java:35)
at org.apache.felix.gogo.runtime.shell.CommandProxy.execute(CommandProxy.java:50)
at org.apache.felix.gogo.runtime.shell.Closure.execute(Closure.java:229)
at org.apache.felix.gogo.runtime.shell.Closure.executeStatement(Closure.java:162)
at org.apache.felix.gogo.runtime.shell.Pipe.run(Pipe.java:101)
at org.apache.felix.gogo.runtime.shell.Closure.execute(Closure.java:79)
at org.apache.felix.gogo.runtime.shell.CommandSessionImpl.execute(CommandSessionImpl.java:71)
at org.apache.karaf.shell.console.jline.Console.run(Console.java:180)
at java.lang.Thread.run(Thread.java:637)
{code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (KARAF-133) NPE when installing a bundle with a
MANIFEST.MF not in the first entry of the zip
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Guillaume Nodet updated KARAF-133:
----------------------------------
Priority: Trivial (was: Major)
> NPE when installing a bundle with a MANIFEST.MF not in the first entry of the zip
> ---------------------------------------------------------------------------------
>
> Key: KARAF-133
> URL: https://issues.apache.org/jira/browse/KARAF-133
> Project: Karaf
> Issue Type: Bug
> Reporter: Guillaume Nodet
> Priority: Trivial
>
> I don't think we should necesseraly support those jars, as it would force us to download the whole jar, but we should at least throw a meaningful exception
> {code}
> java.lang.NullPointerException
> at org.apache.karaf.features.internal.FeaturesServiceImpl.installBundleIfNeeded(FeaturesServiceImpl.java:560)
> at org.apache.karaf.features.internal.FeaturesServiceImpl.doInstallFeature(FeaturesServiceImpl.java:401)
> at org.apache.karaf.features.internal.FeaturesServiceImpl.installFeatures(FeaturesServiceImpl.java:246)
> at org.apache.karaf.features.internal.FeaturesServiceImpl.installFeature(FeaturesServiceImpl.java:235)
> at org.apache.karaf.features.internal.FeaturesServiceImpl.installFeature(FeaturesServiceImpl.java:231)
> at org.apache.karaf.features.command.InstallFeatureCommand.doExecute(InstallFeatureCommand.java:51)
> at org.apache.karaf.features.command.FeaturesCommandSupport.doExecute(FeaturesCommandSupport.java:39)
> at org.apache.karaf.shell.console.OsgiCommandSupport.execute(OsgiCommandSupport.java:41)
> at org.apache.felix.gogo.commands.basic.AbstractCommand.execute(AbstractCommand.java:35)
> at org.apache.felix.gogo.runtime.shell.CommandProxy.execute(CommandProxy.java:50)
> at org.apache.felix.gogo.runtime.shell.Closure.execute(Closure.java:229)
> at org.apache.felix.gogo.runtime.shell.Closure.executeStatement(Closure.java:162)
> at org.apache.felix.gogo.runtime.shell.Pipe.run(Pipe.java:101)
> at org.apache.felix.gogo.runtime.shell.Closure.execute(Closure.java:79)
> at org.apache.felix.gogo.runtime.shell.CommandSessionImpl.execute(CommandSessionImpl.java:71)
> at org.apache.karaf.shell.console.jline.Console.run(Console.java:180)
> at java.lang.Thread.run(Thread.java:637)
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (KARAF-133) NPE when installing a bundle with a
MANIFEST.MF not in the first entry of the zip
Posted by "Ioannis Canellos (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ioannis Canellos updated KARAF-133:
-----------------------------------
Attachment: manifest-not-found-patch.txt
I am attaching a patch that adds a simple check on the manifest object and throws a BundleException with a message "Manifest not present in the first entry of the zip" if the Manifest object is null.
> NPE when installing a bundle with a MANIFEST.MF not in the first entry of the zip
> ---------------------------------------------------------------------------------
>
> Key: KARAF-133
> URL: https://issues.apache.org/jira/browse/KARAF-133
> Project: Karaf
> Issue Type: Bug
> Reporter: Guillaume Nodet
> Priority: Trivial
> Attachments: manifest-not-found-patch.txt
>
>
> I don't think we should necesseraly support those jars, as it would force us to download the whole jar, but we should at least throw a meaningful exception
> {code}
> java.lang.NullPointerException
> at org.apache.karaf.features.internal.FeaturesServiceImpl.installBundleIfNeeded(FeaturesServiceImpl.java:560)
> at org.apache.karaf.features.internal.FeaturesServiceImpl.doInstallFeature(FeaturesServiceImpl.java:401)
> at org.apache.karaf.features.internal.FeaturesServiceImpl.installFeatures(FeaturesServiceImpl.java:246)
> at org.apache.karaf.features.internal.FeaturesServiceImpl.installFeature(FeaturesServiceImpl.java:235)
> at org.apache.karaf.features.internal.FeaturesServiceImpl.installFeature(FeaturesServiceImpl.java:231)
> at org.apache.karaf.features.command.InstallFeatureCommand.doExecute(InstallFeatureCommand.java:51)
> at org.apache.karaf.features.command.FeaturesCommandSupport.doExecute(FeaturesCommandSupport.java:39)
> at org.apache.karaf.shell.console.OsgiCommandSupport.execute(OsgiCommandSupport.java:41)
> at org.apache.felix.gogo.commands.basic.AbstractCommand.execute(AbstractCommand.java:35)
> at org.apache.felix.gogo.runtime.shell.CommandProxy.execute(CommandProxy.java:50)
> at org.apache.felix.gogo.runtime.shell.Closure.execute(Closure.java:229)
> at org.apache.felix.gogo.runtime.shell.Closure.executeStatement(Closure.java:162)
> at org.apache.felix.gogo.runtime.shell.Pipe.run(Pipe.java:101)
> at org.apache.felix.gogo.runtime.shell.Closure.execute(Closure.java:79)
> at org.apache.felix.gogo.runtime.shell.CommandSessionImpl.execute(CommandSessionImpl.java:71)
> at org.apache.karaf.shell.console.jline.Console.run(Console.java:180)
> at java.lang.Thread.run(Thread.java:637)
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (KARAF-133) NPE when installing a bundle with a
MANIFEST.MF not in the first entry of the zip
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Guillaume Nodet resolved KARAF-133.
-----------------------------------
Assignee: Guillaume Nodet
Fix Version/s: 2.2.0
Resolution: Fixed
Committing to https://svn.apache.org/repos/asf/karaf/trunk ...
M features/core/src/main/java/org/apache/karaf/features/internal/FeaturesServiceImpl.java
Committed r985818
Thanks for the patch Ioannis :-)
> NPE when installing a bundle with a MANIFEST.MF not in the first entry of the zip
> ---------------------------------------------------------------------------------
>
> Key: KARAF-133
> URL: https://issues.apache.org/jira/browse/KARAF-133
> Project: Karaf
> Issue Type: Bug
> Reporter: Guillaume Nodet
> Assignee: Guillaume Nodet
> Priority: Trivial
> Fix For: 2.2.0
>
> Attachments: manifest-not-found-patch.txt
>
>
> I don't think we should necesseraly support those jars, as it would force us to download the whole jar, but we should at least throw a meaningful exception
> {code}
> java.lang.NullPointerException
> at org.apache.karaf.features.internal.FeaturesServiceImpl.installBundleIfNeeded(FeaturesServiceImpl.java:560)
> at org.apache.karaf.features.internal.FeaturesServiceImpl.doInstallFeature(FeaturesServiceImpl.java:401)
> at org.apache.karaf.features.internal.FeaturesServiceImpl.installFeatures(FeaturesServiceImpl.java:246)
> at org.apache.karaf.features.internal.FeaturesServiceImpl.installFeature(FeaturesServiceImpl.java:235)
> at org.apache.karaf.features.internal.FeaturesServiceImpl.installFeature(FeaturesServiceImpl.java:231)
> at org.apache.karaf.features.command.InstallFeatureCommand.doExecute(InstallFeatureCommand.java:51)
> at org.apache.karaf.features.command.FeaturesCommandSupport.doExecute(FeaturesCommandSupport.java:39)
> at org.apache.karaf.shell.console.OsgiCommandSupport.execute(OsgiCommandSupport.java:41)
> at org.apache.felix.gogo.commands.basic.AbstractCommand.execute(AbstractCommand.java:35)
> at org.apache.felix.gogo.runtime.shell.CommandProxy.execute(CommandProxy.java:50)
> at org.apache.felix.gogo.runtime.shell.Closure.execute(Closure.java:229)
> at org.apache.felix.gogo.runtime.shell.Closure.executeStatement(Closure.java:162)
> at org.apache.felix.gogo.runtime.shell.Pipe.run(Pipe.java:101)
> at org.apache.felix.gogo.runtime.shell.Closure.execute(Closure.java:79)
> at org.apache.felix.gogo.runtime.shell.CommandSessionImpl.execute(CommandSessionImpl.java:71)
> at org.apache.karaf.shell.console.jline.Console.run(Console.java:180)
> at java.lang.Thread.run(Thread.java:637)
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.