You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2020/05/07 16:22:21 UTC
[GitHub] [sling-apache-sling-jar-resource-bundle] cmrockwell opened a new pull request #1: Update NOTICE.vm
cmrockwell opened a new pull request #1:
URL: https://github.com/apache/sling-apache-sling-jar-resource-bundle/pull/1
allow projects to append to the NOTICE
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-apache-sling-jar-resource-bundle] cmrockwell commented on pull request #1: SLING-9397: Update NOTICE.vm
Posted by GitBox <gi...@apache.org>.
cmrockwell commented on pull request #1:
URL: https://github.com/apache/sling-apache-sling-jar-resource-bundle/pull/1#issuecomment-625835017
@rombert The changes you suggested should be all set.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-apache-sling-jar-resource-bundle] rombert commented on a change in pull request #1: SLING-9397: Update NOTICE.vm
Posted by GitBox <gi...@apache.org>.
rombert commented on a change in pull request #1:
URL: https://github.com/apache/sling-apache-sling-jar-resource-bundle/pull/1#discussion_r422000899
##########
File path: src/main/resources/META-INF/NOTICE.vm
##########
@@ -18,14 +18,19 @@
##
#if ($projectName)$projectName#else${project.name}#end
+#if ($project.properties.noticeStatement)
+ $project.properties.noticeStatement
+#end
Copyright ${projectTimespan}#if($project.organization.name) $project.organization.name#else The Apache Software Foundation#end
-
-Apache Sling is based on source code originally developed
+Apache Sling is based on source code originally developed
by Day Software (http://www.day.com/).
This product includes software developed at
The Apache Software Foundation (http://www.apache.org/).
+
Review comment:
Please remove this whitespace-only change.
##########
File path: src/main/resources/META-INF/NOTICE.vm
##########
@@ -18,14 +18,19 @@
##
#if ($projectName)$projectName#else${project.name}#end
+#if ($project.properties.noticeStatement)
+ $project.properties.noticeStatement
+#end
Copyright ${projectTimespan}#if($project.organization.name) $project.organization.name#else The Apache Software Foundation#end
-
-Apache Sling is based on source code originally developed
+Apache Sling is based on source code originally developed
Review comment:
Please remove this whitespace-only change.
##########
File path: src/main/resources/META-INF/NOTICE.vm
##########
@@ -18,14 +18,19 @@
##
#if ($projectName)$projectName#else${project.name}#end
+#if ($project.properties.noticeStatement)
Review comment:
Is this picked up from the pom.xml properties? Also, ca you please move this to the end of the file?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-apache-sling-jar-resource-bundle] sonarcloud[bot] removed a comment on pull request #1: SLING-9436: Update NOTICE.vm
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on pull request #1:
URL: https://github.com/apache/sling-apache-sling-jar-resource-bundle/pull/1#issuecomment-625758682
Kudos, SonarCloud Quality Gate passed!
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-apache-sling-jar-resource-bundle&pullRequest=1&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-apache-sling-jar-resource-bundle&pullRequest=1&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-apache-sling-jar-resource-bundle&pullRequest=1&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-apache-sling-jar-resource-bundle&pullRequest=1&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-apache-sling-jar-resource-bundle&pullRequest=1&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-apache-sling-jar-resource-bundle&pullRequest=1&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-apache-sling-jar-resource-bundle&pullRequest=1&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-apache-sling-jar-resource-bundle&pullRequest=1&resolved=false&types=SECURITY_HOTSPOT) to review)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-apache-sling-jar-resource-bundle&pullRequest=1&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-apache-sling-jar-resource-bundle&pullRequest=1&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-apache-sling-jar-resource-bundle&pullRequest=1&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png' alt='No Coverage information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-apache-sling-jar-resource-bundle&pullRequest=1) No Coverage information
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo.png' alt='No Duplication information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-apache-sling-jar-resource-bundle&pullRequest=1&metric=duplicated_lines_density&view=list) No Duplication information
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-apache-sling-jar-resource-bundle] rombert commented on pull request #1: SLING-9397: Update NOTICE.vm
Posted by GitBox <gi...@apache.org>.
rombert commented on pull request #1:
URL: https://github.com/apache/sling-apache-sling-jar-resource-bundle/pull/1#issuecomment-625691123
Also, please squash all commits into one once you have applied the changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-apache-sling-jar-resource-bundle] rombert commented on pull request #1: SLING-9436: Update NOTICE.vm
Posted by GitBox <gi...@apache.org>.
rombert commented on pull request #1:
URL: https://github.com/apache/sling-apache-sling-jar-resource-bundle/pull/1#issuecomment-626517490
Applied, thanks @cmrockwell !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-apache-sling-jar-resource-bundle] rombert removed a comment on pull request #1: SLING-9397: Update NOTICE.vm
Posted by GitBox <gi...@apache.org>.
rombert removed a comment on pull request #1:
URL: https://github.com/apache/sling-apache-sling-jar-resource-bundle/pull/1#issuecomment-625691123
Two high-level comments:
- please squash all commits into one once you have applied the changes.
- please create a new Jira for this change, we need to track it separately ( version is https://issues.apache.org/jira/projects/SLING/versions/12348248 ). I will then release this bundle, pull it into the parent pom and release that one as well, so you can reference it in the SAML handler
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-apache-sling-jar-resource-bundle] sonarcloud[bot] commented on pull request #1: SLING-9397: Update NOTICE.vm
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #1:
URL: https://github.com/apache/sling-apache-sling-jar-resource-bundle/pull/1#issuecomment-625758682
Kudos, SonarCloud Quality Gate passed!
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-apache-sling-jar-resource-bundle&pullRequest=1&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-apache-sling-jar-resource-bundle&pullRequest=1&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-apache-sling-jar-resource-bundle&pullRequest=1&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-apache-sling-jar-resource-bundle&pullRequest=1&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-apache-sling-jar-resource-bundle&pullRequest=1&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-apache-sling-jar-resource-bundle&pullRequest=1&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-apache-sling-jar-resource-bundle&pullRequest=1&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-apache-sling-jar-resource-bundle&pullRequest=1&resolved=false&types=SECURITY_HOTSPOT) to review)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-apache-sling-jar-resource-bundle&pullRequest=1&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-apache-sling-jar-resource-bundle&pullRequest=1&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-apache-sling-jar-resource-bundle&pullRequest=1&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png' alt='No Coverage information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-apache-sling-jar-resource-bundle&pullRequest=1) No Coverage information
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo.png' alt='No Duplication information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-apache-sling-jar-resource-bundle&pullRequest=1&metric=duplicated_lines_density&view=list) No Duplication information
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-apache-sling-jar-resource-bundle] rombert edited a comment on pull request #1: SLING-9397: Update NOTICE.vm
Posted by GitBox <gi...@apache.org>.
rombert edited a comment on pull request #1:
URL: https://github.com/apache/sling-apache-sling-jar-resource-bundle/pull/1#issuecomment-625691123
Two high-level comments:
- please squash all commits into one once you have applied the changes.
- please create a new Jira for this change, we need to track it separately ( version is https://issues.apache.org/jira/projects/SLING/versions/12348248 ). I will then release this bundle, pull it into the parent pom and release that one as well, so you can reference it in the SAML handler
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-apache-sling-jar-resource-bundle] sonarcloud[bot] commented on pull request #1: SLING-9436: Update NOTICE.vm
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #1:
URL: https://github.com/apache/sling-apache-sling-jar-resource-bundle/pull/1#issuecomment-626148359
Kudos, SonarCloud Quality Gate passed!
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-apache-sling-jar-resource-bundle&pullRequest=1&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-apache-sling-jar-resource-bundle&pullRequest=1&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-apache-sling-jar-resource-bundle&pullRequest=1&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-apache-sling-jar-resource-bundle&pullRequest=1&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-apache-sling-jar-resource-bundle&pullRequest=1&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-apache-sling-jar-resource-bundle&pullRequest=1&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-apache-sling-jar-resource-bundle&pullRequest=1&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-apache-sling-jar-resource-bundle&pullRequest=1&resolved=false&types=SECURITY_HOTSPOT) to review)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-apache-sling-jar-resource-bundle&pullRequest=1&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-apache-sling-jar-resource-bundle&pullRequest=1&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-apache-sling-jar-resource-bundle&pullRequest=1&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png' alt='No Coverage information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-apache-sling-jar-resource-bundle&pullRequest=1) No Coverage information
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo.png' alt='No Duplication information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-apache-sling-jar-resource-bundle&pullRequest=1&metric=duplicated_lines_density&view=list) No Duplication information
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org