You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Hexiaoqiao (via GitHub)" <gi...@apache.org> on 2023/09/26 12:05:40 UTC

[GitHub] [hadoop] Hexiaoqiao commented on a diff in pull request #6109: HDFS-17208. Add the metrics PendingAsyncDiskOperations in datanode

Hexiaoqiao commented on code in PR #6109:
URL: https://github.com/apache/hadoop/pull/6109#discussion_r1337102710


##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java:
##########
@@ -3822,5 +3822,10 @@ public long getLastDirScannerFinishTime() {
   public void setLastDirScannerFinishTime(long time) {
     this.lastDirScannerFinishTime = time;
   }
+
+  @Override
+  public long getPendingAsyncDiskOperations() {

Review Comment:
   `getPendingAsyncDeletions` should be more readable?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org