You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/05/01 16:33:02 UTC
[GitHub] [incubator-pekko-connectors] mdedetrich opened a new pull request, #88: Rename getBucketVersioningEnabled to isBucketVersioningEnabled
mdedetrich opened a new pull request, #88:
URL: https://github.com/apache/incubator-pekko-connectors/pull/88
@pjfanning
This is naming is more appropriate for Java API's
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] mdedetrich commented on pull request #88: Rename getBucketVersioningEnabled to isBucketVersioningEnabled
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #88:
URL: https://github.com/apache/incubator-pekko-connectors/pull/88#issuecomment-1529935610
Actually I am going to close this PR, not because its valid but because it would be inconsistent with the rest of the codebase (i.e. https://github.com/mdedetrich/incubator-pekko-connectors/blob/8b986332794e34450e25d9a4464591816c007faa/s3/src/main/scala/org/apache/pekko/stream/connectors/s3/model.scala#L680).
There is definitely merit in changing the naming in general but this should be done comprehensively at once and hence its likely to target 1.1.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] mdedetrich closed pull request #88: Rename getBucketVersioningEnabled to isBucketVersioningEnabled
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich closed pull request #88: Rename getBucketVersioningEnabled to isBucketVersioningEnabled
URL: https://github.com/apache/incubator-pekko-connectors/pull/88
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org