You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by vgmartinez <gi...@git.apache.org> on 2015/10/13 12:08:36 UTC
[GitHub] incubator-zeppelin pull request: ZEPPELIN-307: Not is added a new ...
GitHub user vgmartinez opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/340
ZEPPELIN-307: Not is added a new empty paragraph at the end of the note
Add a new paragraph when the note is autosaved
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vgmartinez/incubator-zeppelin add_new_paragraph
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/340.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #340
----
commit f5725ad4c55f8769e353a58f874fd1686352726b
Author: Victor <vi...@gmail.com>
Date: 2015-10-13T10:02:23Z
add an empty paragraph at the end of the note
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-307: Added a new empty p...
Posted by vgmartinez <gi...@git.apache.org>.
Github user vgmartinez closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/340
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-307: Added a new empty p...
Posted by vgmartinez <gi...@git.apache.org>.
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/340#issuecomment-147706453
Hi @Leemoonsoo,
I'm not sure but the test should not be used commitParagraph ....? which is exactly what I should do .... I'm a little confused.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-307: Added a new empty p...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/340#issuecomment-147712767
Basically, a unittest that fails without this patch and passes with this patch.
I thought little bit more about this action. Current rule of paragraph creation is
1. automatically adds one after execution of last paragraph.
2. manually inserts between paragraphs.
And this patch changes to
1. automatically adds one, after execution of last paragraph.
2. manually inserts between paragraphs.
3. automatically adds one, after saving non empty last paragraph.
I think it could be confusing, if i see a new paragraph created automatically, while editing the last paragraph. Another strategy, with less confusing(i think) is,
1. automatically adds one, after execution of last paragraph.
2. manually inserts between paragraphs.
3. automatically adds one, when user starts editing the last paragraph.
I personally prefer the current rule, but what do you guys think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-307: Added a new empty p...
Posted by vgmartinez <gi...@git.apache.org>.
Github user vgmartinez commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/340#issuecomment-147721881
I also prefer the current rule
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-307: Added a new empty p...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/340#issuecomment-147855146
And sometimes one does not want a new paragraph created automatically
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-307: Added a new empty p...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/340#issuecomment-147692673
Change looks good. But can we have an unittest for it before merge?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-307: Added a new empty p...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/340#issuecomment-147855008
Since the auto-save is timer based, I do agree it is confusing to see a new paragraph appearing by itself.
I agree with @Leemoonsoo that the 'add paragraph when editing last' is more predictable and potentially less confusing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---