[GitHub] [superset] lilykuang commented on a change in pull request #19242: fix: allow subquery in ad-hoc SQL (WIP)

[GitBox <gi...@apache.org>]

lilykuang commented on a change in pull request #19242:
URL: https://github.com/apache/superset/pull/19242#discussion_r829624321



##########
File path: superset/connectors/sqla/models.py
##########
@@ -1180,7 +1184,7 @@ def get_sqla_query(  # pylint: disable=too-many-arguments,too-many-locals,too-ma
             for selected in columns:
                 select_exprs.append(
                     columns_by_name[selected].get_sqla_col()
-                    if selected in columns_by_name
+                    if selected in columns_by_name and validate_adhoc_subquery(selected)

Review comment:
       that makes sense. thank you for clarifying your comments. I will update the method accordingly 😄.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org