You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Jakob Homan (JIRA)" <ji...@apache.org> on 2008/08/05 20:18:44 UTC
[jira] Created: (ZOOKEEPER-110) Build script relies on svnant,
which is not compatible with subversion 1.5 working copies
Build script relies on svnant, which is not compatible with subversion 1.5 working copies
-----------------------------------------------------------------------------------------
Key: ZOOKEEPER-110
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110
Project: Zookeeper
Issue Type: Bug
Components: build
Affects Versions: 3.0.0
Environment: Subversion 1.5 command line, or subclipse version 1.4.x
Reporter: Jakob Homan
The current build.xml ant script uses svnant to obtain the latest revision number from the repo, however svnant is not compatible with subversion 1.5 (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build fails with working copies checked out by this version. The build fails with "this version of subversion is too old, please get a newer version..." This will become more apparent as svn 1.5 trickles out; I'm using a brand new dev environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather quickly.
Those with svn 1.5 can get the code from the trunk, but cannot do an ant build.
svnant hasn't been updated in more than a year and appears to be dead, so it may no longer be a viable tool for the ant build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-110) Build script relies on svnant,
which is not compatible with subversion 1.5 working copies
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated ZOOKEEPER-110:
----------------------------------
Attachment: ZOOKEEPER-110.patch
renamed patch, deleted old version.
> Build script relies on svnant, which is not compatible with subversion 1.5 working copies
> -----------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-110
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110
> Project: Zookeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.0.0
> Environment: Subversion 1.5 command line, or subclipse version 1.4.x
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: ZOOKEEPER-110.patch
>
>
> The current build.xml ant script uses svnant to obtain the latest revision number from the repo, however svnant is not compatible with subversion 1.5 (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build fails with working copies checked out by this version. The build fails with "this version of subversion is too old, please get a newer version..." This will become more apparent as svn 1.5 trickles out; I'm using a brand new dev environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather quickly.
> Those with svn 1.5 can get the code from the trunk, but cannot do an ant build.
> svnant hasn't been updated in more than a year and appears to be dead, so it may no longer be a viable tool for the ant build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (ZOOKEEPER-110) Build script relies on
svnant, which is not compatible with subversion 1.5 working copies
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620368#action_12620368 ]
jghoman edited comment on ZOOKEEPER-110 at 8/6/08 11:33 AM:
----------------------------------------------------------------
Yes, in the ant exec task you can specify which os the command should run on, so we should be able to write two separate exec tasks: one for win, one for *nix. I'm writing the script for linux now/modifying the buld.xml and will upload the patch in a bit. I can look at how to do it in windows as well, but I'm not sure how to get the info without a good scripting environment. Sorry if it was incorrect to upload the patch that required the bad license. -jg
was (Author: jghoman):
Yes, in the ant exec task you can specify which os the command should run on, so we should be able to write two separate exec tasks: one for win, one for *nix. I'm writing the script for linux now/modifying the buld.xml and will upload the patch in a bit. I can look at how to do it in windows as well, but I'm not sure how to get the info within a good scripting environment. Sorry if it was incorrect to upload the patch that required the bad license. -jg
> Build script relies on svnant, which is not compatible with subversion 1.5 working copies
> -----------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-110
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110
> Project: Zookeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.0.0
> Environment: Subversion 1.5 command line, or subclipse version 1.4.x
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: svntask.diff
>
>
> The current build.xml ant script uses svnant to obtain the latest revision number from the repo, however svnant is not compatible with subversion 1.5 (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build fails with working copies checked out by this version. The build fails with "this version of subversion is too old, please get a newer version..." This will become more apparent as svn 1.5 trickles out; I'm using a brand new dev environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather quickly.
> Those with svn 1.5 can get the code from the trunk, but cannot do an ant build.
> svnant hasn't been updated in more than a year and appears to be dead, so it may no longer be a viable tool for the ant build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-110) Build script relies on svnant,
which is not compatible with subversion 1.5 working copies
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated ZOOKEEPER-110:
----------------------------------
Attachment: svntask.diff
Patch removes svnant and adds svntask.
> Build script relies on svnant, which is not compatible with subversion 1.5 working copies
> -----------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-110
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110
> Project: Zookeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.0.0
> Environment: Subversion 1.5 command line, or subclipse version 1.4.x
> Reporter: Jakob Homan
> Attachments: svntask.diff
>
>
> The current build.xml ant script uses svnant to obtain the latest revision number from the repo, however svnant is not compatible with subversion 1.5 (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build fails with working copies checked out by this version. The build fails with "this version of subversion is too old, please get a newer version..." This will become more apparent as svn 1.5 trickles out; I'm using a brand new dev environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather quickly.
> Those with svn 1.5 can get the code from the trunk, but cannot do an ant build.
> svnant hasn't been updated in more than a year and appears to be dead, so it may no longer be a viable tool for the ant build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-110) Build script relies on svnant,
which is not compatible with subversion 1.5 working copies
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated ZOOKEEPER-110:
----------------------------------
Attachment: ZOOKEEPER-110.patch
Added Apache liecense header to both new files.
> Build script relies on svnant, which is not compatible with subversion 1.5 working copies
> -----------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-110
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110
> Project: Zookeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.0.0
> Environment: Subversion 1.5 command line, or subclipse version 1.4.x
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: ZOOKEEPER-110.patch, ZOOKEEPER-110.patch, ZOOKEEPER-110.patch
>
>
> The current build.xml ant script uses svnant to obtain the latest revision number from the repo, however svnant is not compatible with subversion 1.5 (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build fails with working copies checked out by this version. The build fails with "this version of subversion is too old, please get a newer version..." This will become more apparent as svn 1.5 trickles out; I'm using a brand new dev environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather quickly.
> Those with svn 1.5 can get the code from the trunk, but cannot do an ant build.
> svnant hasn't been updated in more than a year and appears to be dead, so it may no longer be a viable tool for the ant build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-110) Build script relies on svnant,
which is not compatible with subversion 1.5 working copies
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated ZOOKEEPER-110:
----------------------------------
Attachment: revthrushell.diff
I've re-done the patch to use a shell script to obtain the revision number, ala Hadoop's approach. This works on *nix machines, maintains functionality, removes the reliance on svnant (which can be deleted from the lib directory) and introduces no new dependencies.
As far as Windows machines go, the operating system's poor default scripting environment makes this rather easy task pretty difficult. However, it would be easy enough to do in MS Powershell, and I don't think it's unreasonable to expect developers' machines to have that tool installed at this point. So I could certainly write up an equivalent script in Powershell, create another exec task targeted to Windows, and we'd be back to good without introducing a cygwin dependency (just a Powershell one). One unknown: I don't know how ant would identify a Windows machine with cygwin but without Powershell. Let me know if this sounds reasonable. If so, I can explore that option.
Hope this is useful. -jg
> Build script relies on svnant, which is not compatible with subversion 1.5 working copies
> -----------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-110
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110
> Project: Zookeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.0.0
> Environment: Subversion 1.5 command line, or subclipse version 1.4.x
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: revthrushell.diff, svntask.diff
>
>
> The current build.xml ant script uses svnant to obtain the latest revision number from the repo, however svnant is not compatible with subversion 1.5 (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build fails with working copies checked out by this version. The build fails with "this version of subversion is too old, please get a newer version..." This will become more apparent as svn 1.5 trickles out; I'm using a brand new dev environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather quickly.
> Those with svn 1.5 can get the code from the trunk, but cannot do an ant build.
> svnant hasn't been updated in more than a year and appears to be dead, so it may no longer be a viable tool for the ant build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-110) Build script relies on svnant,
which is not compatible with subversion 1.5 working copies
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620364#action_12620364 ]
Patrick Hunt commented on ZOOKEEPER-110:
----------------------------------------
We don't want to add dependency on cygwin for zookeeper.
What other options are available? In ant there is no way to determine we are on windows and run another script?
> Build script relies on svnant, which is not compatible with subversion 1.5 working copies
> -----------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-110
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110
> Project: Zookeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.0.0
> Environment: Subversion 1.5 command line, or subclipse version 1.4.x
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: svntask.diff
>
>
> The current build.xml ant script uses svnant to obtain the latest revision number from the repo, however svnant is not compatible with subversion 1.5 (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build fails with working copies checked out by this version. The build fails with "this version of subversion is too old, please get a newer version..." This will become more apparent as svn 1.5 trickles out; I'm using a brand new dev environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather quickly.
> Those with svn 1.5 can get the code from the trunk, but cannot do an ant build.
> svnant hasn't been updated in more than a year and appears to be dead, so it may no longer be a viable tool for the ant build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-110) Build script relies on svnant,
which is not compatible with subversion 1.5 working copies
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620037#action_12620037 ]
Owen O'Malley commented on ZOOKEEPER-110:
-----------------------------------------
My reading of the svnkit license would make it incompatible with the Apache license. If it is incompatible, you can not depend on it or distribute it as part of Zookeeper. See http://www.apache.org/legal/3party.html . If there isn't away to avoid svnkit or fix svnant, you can ask legal about the TMate license. In my opinion, the clause that will be fatal is:
{quote}
* Redistribution in any form without redistributing source code for software
that uses SVNKit is possible only when such redistribution is explictly permitted
by TMate Software. Please, contact TMate Software at support@svnkit.com to
get such permission.
{quote}
which is effectively a GPL-like viral clause with an escape clause that lets TMate give/sell exceptions.
> Build script relies on svnant, which is not compatible with subversion 1.5 working copies
> -----------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-110
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110
> Project: Zookeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.0.0
> Environment: Subversion 1.5 command line, or subclipse version 1.4.x
> Reporter: Jakob Homan
> Attachments: svntask.diff
>
>
> The current build.xml ant script uses svnant to obtain the latest revision number from the repo, however svnant is not compatible with subversion 1.5 (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build fails with working copies checked out by this version. The build fails with "this version of subversion is too old, please get a newer version..." This will become more apparent as svn 1.5 trickles out; I'm using a brand new dev environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather quickly.
> Those with svn 1.5 can get the code from the trunk, but cannot do an ant build.
> svnant hasn't been updated in more than a year and appears to be dead, so it may no longer be a viable tool for the ant build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-110) Build script relies on svnant,
which is not compatible with subversion 1.5 working copies
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated ZOOKEEPER-110:
----------------------------------
Comment: was deleted
> Build script relies on svnant, which is not compatible with subversion 1.5 working copies
> -----------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-110
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110
> Project: Zookeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.0.0
> Environment: Subversion 1.5 command line, or subclipse version 1.4.x
> Reporter: Jakob Homan
> Attachments: svntask.diff
>
>
> The current build.xml ant script uses svnant to obtain the latest revision number from the repo, however svnant is not compatible with subversion 1.5 (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build fails with working copies checked out by this version. The build fails with "this version of subversion is too old, please get a newer version..." This will become more apparent as svn 1.5 trickles out; I'm using a brand new dev environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather quickly.
> Those with svn 1.5 can get the code from the trunk, but cannot do an ant build.
> svnant hasn't been updated in more than a year and appears to be dead, so it may no longer be a viable tool for the ant build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-110) Build script relies on svnant,
which is not compatible with subversion 1.5 working copies
Posted by "Andrew Kornev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620329#action_12620329 ]
Andrew Kornev commented on ZOOKEEPER-110:
-----------------------------------------
I'd like to point out that the hadoop's solution is non-portable. The <exec> task will fail on Windows -- it won't be able to find the executable "sh.exe". By the way, this portability issue was one of the reasons we had to use svnant.
> Build script relies on svnant, which is not compatible with subversion 1.5 working copies
> -----------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-110
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110
> Project: Zookeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.0.0
> Environment: Subversion 1.5 command line, or subclipse version 1.4.x
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: svntask.diff
>
>
> The current build.xml ant script uses svnant to obtain the latest revision number from the repo, however svnant is not compatible with subversion 1.5 (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build fails with working copies checked out by this version. The build fails with "this version of subversion is too old, please get a newer version..." This will become more apparent as svn 1.5 trickles out; I'm using a brand new dev environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather quickly.
> Those with svn 1.5 can get the code from the trunk, but cannot do an ant build.
> svnant hasn't been updated in more than a year and appears to be dead, so it may no longer be a viable tool for the ant build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-110) Build script relies on svnant,
which is not compatible with subversion 1.5 working copies
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-110:
-----------------------------------
Fix Version/s: 3.0.0
> Build script relies on svnant, which is not compatible with subversion 1.5 working copies
> -----------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-110
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110
> Project: Zookeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.0.0
> Environment: Subversion 1.5 command line, or subclipse version 1.4.x
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Fix For: 3.0.0
>
> Attachments: ZOOKEEPER-110.patch, ZOOKEEPER-110.patch, ZOOKEEPER-110.patch, ZOOKEEPER-110.patch
>
>
> The current build.xml ant script uses svnant to obtain the latest revision number from the repo, however svnant is not compatible with subversion 1.5 (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build fails with working copies checked out by this version. The build fails with "this version of subversion is too old, please get a newer version..." This will become more apparent as svn 1.5 trickles out; I'm using a brand new dev environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather quickly.
> Those with svn 1.5 can get the code from the trunk, but cannot do an ant build.
> svnant hasn't been updated in more than a year and appears to be dead, so it may no longer be a viable tool for the ant build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-110) Build script relies on svnant,
which is not compatible with subversion 1.5 working copies
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated ZOOKEEPER-110:
----------------------------------
Attachment: ZOOKEEPER-110.patch
OK, I've coded up a DOS batch file that exactly replicates the shell script using only Windows built-in commands, so this fixes the original problem I identified, removes the svnant dependency, adds no new dependencies and will work on Windows natively. Huzzah!
I tested it on my OSX, Ubuntu and XP machines and they all worked.
Again, the patch doesn't reflect deleting the svnant directory and contents.
-jg
> Build script relies on svnant, which is not compatible with subversion 1.5 working copies
> -----------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-110
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110
> Project: Zookeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.0.0
> Environment: Subversion 1.5 command line, or subclipse version 1.4.x
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: ZOOKEEPER-110.patch, ZOOKEEPER-110.patch
>
>
> The current build.xml ant script uses svnant to obtain the latest revision number from the repo, however svnant is not compatible with subversion 1.5 (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build fails with working copies checked out by this version. The build fails with "this version of subversion is too old, please get a newer version..." This will become more apparent as svn 1.5 trickles out; I'm using a brand new dev environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather quickly.
> Those with svn 1.5 can get the code from the trunk, but cannot do an ant build.
> svnant hasn't been updated in more than a year and appears to be dead, so it may no longer be a viable tool for the ant build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-110) Build script relies on svnant,
which is not compatible with subversion 1.5 working copies
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620404#action_12620404 ]
Patrick Hunt commented on ZOOKEEPER-110:
----------------------------------------
I noticed this in the ant exec manpage:
Cygwin Users
The <exec> task will not understand paths such as /bin/sh for the executable parameter. This is because the Java VM in which Ant is running is a standard Windows executable and is not aware of the Cygwin environment (i.e., doesn't load cygwin1.dll). The only work-around for this is to compile a JVM under Cygwin (at your own risk). See for instance sun jdk 6 build instructions for cygwin.
I created a simple build.xml and regardless of whether I run under cmd or cygwin bash I still get "Windows XP" as the os.name.
What about Mac users, are they covered as well?
> Build script relies on svnant, which is not compatible with subversion 1.5 working copies
> -----------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-110
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110
> Project: Zookeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.0.0
> Environment: Subversion 1.5 command line, or subclipse version 1.4.x
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: revthrushell.diff, svntask.diff
>
>
> The current build.xml ant script uses svnant to obtain the latest revision number from the repo, however svnant is not compatible with subversion 1.5 (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build fails with working copies checked out by this version. The build fails with "this version of subversion is too old, please get a newer version..." This will become more apparent as svn 1.5 trickles out; I'm using a brand new dev environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather quickly.
> Those with svn 1.5 can get the code from the trunk, but cannot do an ant build.
> svnant hasn't been updated in more than a year and appears to be dead, so it may no longer be a viable tool for the ant build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-110) Build script relies on svnant,
which is not compatible with subversion 1.5 working copies
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated ZOOKEEPER-110:
----------------------------------
Attachment: svntask.diff
patch removes svnant and adds svntask to build script
> Build script relies on svnant, which is not compatible with subversion 1.5 working copies
> -----------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-110
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110
> Project: Zookeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.0.0
> Environment: Subversion 1.5 command line, or subclipse version 1.4.x
> Reporter: Jakob Homan
> Attachments: svntask.diff
>
>
> The current build.xml ant script uses svnant to obtain the latest revision number from the repo, however svnant is not compatible with subversion 1.5 (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build fails with working copies checked out by this version. The build fails with "this version of subversion is too old, please get a newer version..." This will become more apparent as svn 1.5 trickles out; I'm using a brand new dev environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather quickly.
> Those with svn 1.5 can get the code from the trunk, but cannot do an ant build.
> svnant hasn't been updated in more than a year and appears to be dead, so it may no longer be a viable tool for the ant build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-110) Build script relies on svnant,
which is not compatible with subversion 1.5 working copies
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated ZOOKEEPER-110:
----------------------------------
Attachment: (was: svntask.diff)
> Build script relies on svnant, which is not compatible with subversion 1.5 working copies
> -----------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-110
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110
> Project: Zookeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.0.0
> Environment: Subversion 1.5 command line, or subclipse version 1.4.x
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: ZOOKEEPER-110.patch
>
>
> The current build.xml ant script uses svnant to obtain the latest revision number from the repo, however svnant is not compatible with subversion 1.5 (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build fails with working copies checked out by this version. The build fails with "this version of subversion is too old, please get a newer version..." This will become more apparent as svn 1.5 trickles out; I'm using a brand new dev environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather quickly.
> Those with svn 1.5 can get the code from the trunk, but cannot do an ant build.
> svnant hasn't been updated in more than a year and appears to be dead, so it may no longer be a viable tool for the ant build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-110) Build script relies on svnant,
which is not compatible with subversion 1.5 working copies
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620407#action_12620407 ]
Patrick Hunt commented on ZOOKEEPER-110:
----------------------------------------
I'm against (-1) adding any new dependencies... eg powershell.
Andrew -- would you be able to provide a working .bat file?
Jakob -- FYI we are following a convention for patch file naming such as "ZOOKEEPER-110.patch" where the file name is the ID of the jira issue. If you update a patch just re-upload with the same name, jira maintains a history of files with the same name. (please remove the old/invalid patches). Among other things this helps reviewers to keep track of the various patches. Thanks.
> Build script relies on svnant, which is not compatible with subversion 1.5 working copies
> -----------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-110
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110
> Project: Zookeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.0.0
> Environment: Subversion 1.5 command line, or subclipse version 1.4.x
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: revthrushell.diff, svntask.diff
>
>
> The current build.xml ant script uses svnant to obtain the latest revision number from the repo, however svnant is not compatible with subversion 1.5 (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build fails with working copies checked out by this version. The build fails with "this version of subversion is too old, please get a newer version..." This will become more apparent as svn 1.5 trickles out; I'm using a brand new dev environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather quickly.
> Those with svn 1.5 can get the code from the trunk, but cannot do an ant build.
> svnant hasn't been updated in more than a year and appears to be dead, so it may no longer be a viable tool for the ant build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-110) Build script relies on svnant,
which is not compatible with subversion 1.5 working copies
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated ZOOKEEPER-110:
----------------------------------
Attachment: (was: revthrushell.diff)
> Build script relies on svnant, which is not compatible with subversion 1.5 working copies
> -----------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-110
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110
> Project: Zookeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.0.0
> Environment: Subversion 1.5 command line, or subclipse version 1.4.x
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: ZOOKEEPER-110.patch
>
>
> The current build.xml ant script uses svnant to obtain the latest revision number from the repo, however svnant is not compatible with subversion 1.5 (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build fails with working copies checked out by this version. The build fails with "this version of subversion is too old, please get a newer version..." This will become more apparent as svn 1.5 trickles out; I'm using a brand new dev environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather quickly.
> Those with svn 1.5 can get the code from the trunk, but cannot do an ant build.
> svnant hasn't been updated in more than a year and appears to be dead, so it may no longer be a viable tool for the ant build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-110) Build script relies on svnant,
which is not compatible with subversion 1.5 working copies
Posted by "Andrew Kornev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622666#action_12622666 ]
Andrew Kornev commented on ZOOKEEPER-110:
-----------------------------------------
+1 I'll commit the patch and delete the svnant directory and its contents.
> Build script relies on svnant, which is not compatible with subversion 1.5 working copies
> -----------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-110
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110
> Project: Zookeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.0.0
> Environment: Subversion 1.5 command line, or subclipse version 1.4.x
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: ZOOKEEPER-110.patch, ZOOKEEPER-110.patch
>
>
> The current build.xml ant script uses svnant to obtain the latest revision number from the repo, however svnant is not compatible with subversion 1.5 (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build fails with working copies checked out by this version. The build fails with "this version of subversion is too old, please get a newer version..." This will become more apparent as svn 1.5 trickles out; I'm using a brand new dev environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather quickly.
> Those with svn 1.5 can get the code from the trunk, but cannot do an ant build.
> svnant hasn't been updated in more than a year and appears to be dead, so it may no longer be a viable tool for the ant build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-110) Build script relies on svnant,
which is not compatible with subversion 1.5 working copies
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated ZOOKEEPER-110:
----------------------------------
Attachment: (was: svntask.diff)
> Build script relies on svnant, which is not compatible with subversion 1.5 working copies
> -----------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-110
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110
> Project: Zookeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.0.0
> Environment: Subversion 1.5 command line, or subclipse version 1.4.x
> Reporter: Jakob Homan
> Attachments: svntask.diff
>
>
> The current build.xml ant script uses svnant to obtain the latest revision number from the repo, however svnant is not compatible with subversion 1.5 (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build fails with working copies checked out by this version. The build fails with "this version of subversion is too old, please get a newer version..." This will become more apparent as svn 1.5 trickles out; I'm using a brand new dev environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather quickly.
> Those with svn 1.5 can get the code from the trunk, but cannot do an ant build.
> svnant hasn't been updated in more than a year and appears to be dead, so it may no longer be a viable tool for the ant build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (ZOOKEEPER-110) Build script relies on svnant,
which is not compatible with subversion 1.5 working copies
Posted by "Andrew Kornev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Kornev resolved ZOOKEEPER-110.
-------------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Commited the patch, deleted the svnant directory. Thanks, Jakob!
> Build script relies on svnant, which is not compatible with subversion 1.5 working copies
> -----------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-110
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110
> Project: Zookeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.0.0
> Environment: Subversion 1.5 command line, or subclipse version 1.4.x
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: ZOOKEEPER-110.patch, ZOOKEEPER-110.patch, ZOOKEEPER-110.patch, ZOOKEEPER-110.patch
>
>
> The current build.xml ant script uses svnant to obtain the latest revision number from the repo, however svnant is not compatible with subversion 1.5 (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build fails with working copies checked out by this version. The build fails with "this version of subversion is too old, please get a newer version..." This will become more apparent as svn 1.5 trickles out; I'm using a brand new dev environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather quickly.
> Those with svn 1.5 can get the code from the trunk, but cannot do an ant build.
> svnant hasn't been updated in more than a year and appears to be dead, so it may no longer be a viable tool for the ant build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-110) Build script relies on svnant,
which is not compatible with subversion 1.5 working copies
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620323#action_12620323 ]
Owen O'Malley commented on ZOOKEEPER-110:
-----------------------------------------
Basically, the saveVersion script creates a Java source file that defines a package level attribute. There is a utility class that looks for the attribute and uses it if it is available. I took that approach so that the project compiles and runs, even if the script was not run to generate the version information.
> Build script relies on svnant, which is not compatible with subversion 1.5 working copies
> -----------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-110
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110
> Project: Zookeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.0.0
> Environment: Subversion 1.5 command line, or subclipse version 1.4.x
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: svntask.diff
>
>
> The current build.xml ant script uses svnant to obtain the latest revision number from the repo, however svnant is not compatible with subversion 1.5 (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build fails with working copies checked out by this version. The build fails with "this version of subversion is too old, please get a newer version..." This will become more apparent as svn 1.5 trickles out; I'm using a brand new dev environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather quickly.
> Those with svn 1.5 can get the code from the trunk, but cannot do an ant build.
> svnant hasn't been updated in more than a year and appears to be dead, so it may no longer be a viable tool for the ant build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-110) Build script relies on svnant,
which is not compatible with subversion 1.5 working copies
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620340#action_12620340 ]
Owen O'Malley commented on ZOOKEEPER-110:
-----------------------------------------
And the script *does* work on Windows, provided you have cygwin installed.
> Build script relies on svnant, which is not compatible with subversion 1.5 working copies
> -----------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-110
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110
> Project: Zookeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.0.0
> Environment: Subversion 1.5 command line, or subclipse version 1.4.x
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: svntask.diff
>
>
> The current build.xml ant script uses svnant to obtain the latest revision number from the repo, however svnant is not compatible with subversion 1.5 (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build fails with working copies checked out by this version. The build fails with "this version of subversion is too old, please get a newer version..." This will become more apparent as svn 1.5 trickles out; I'm using a brand new dev environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather quickly.
> Those with svn 1.5 can get the code from the trunk, but cannot do an ant build.
> svnant hasn't been updated in more than a year and appears to be dead, so it may no longer be a viable tool for the ant build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-110) Build script relies on svnant,
which is not compatible with subversion 1.5 working copies
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623635#action_12623635 ]
Hudson commented on ZOOKEEPER-110:
----------------------------------
Integrated in ZooKeeper-trunk #58 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/58/])
> Build script relies on svnant, which is not compatible with subversion 1.5 working copies
> -----------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-110
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110
> Project: Zookeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.0.0
> Environment: Subversion 1.5 command line, or subclipse version 1.4.x
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: ZOOKEEPER-110.patch, ZOOKEEPER-110.patch, ZOOKEEPER-110.patch, ZOOKEEPER-110.patch
>
>
> The current build.xml ant script uses svnant to obtain the latest revision number from the repo, however svnant is not compatible with subversion 1.5 (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build fails with working copies checked out by this version. The build fails with "this version of subversion is too old, please get a newer version..." This will become more apparent as svn 1.5 trickles out; I'm using a brand new dev environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather quickly.
> Those with svn 1.5 can get the code from the trunk, but cannot do an ant build.
> svnant hasn't been updated in more than a year and appears to be dead, so it may no longer be a viable tool for the ant build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-110) Build script relies on svnant,
which is not compatible with subversion 1.5 working copies
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622670#action_12622670 ]
Mahadev konar commented on ZOOKEEPER-110:
-----------------------------------------
can we add apache headers to .sh files? all new files need apache headers ....
> Build script relies on svnant, which is not compatible with subversion 1.5 working copies
> -----------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-110
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110
> Project: Zookeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.0.0
> Environment: Subversion 1.5 command line, or subclipse version 1.4.x
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: ZOOKEEPER-110.patch, ZOOKEEPER-110.patch
>
>
> The current build.xml ant script uses svnant to obtain the latest revision number from the repo, however svnant is not compatible with subversion 1.5 (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build fails with working copies checked out by this version. The build fails with "this version of subversion is too old, please get a newer version..." This will become more apparent as svn 1.5 trickles out; I'm using a brand new dev environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather quickly.
> Those with svn 1.5 can get the code from the trunk, but cannot do an ant build.
> svnant hasn't been updated in more than a year and appears to be dead, so it may no longer be a viable tool for the ant build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-110) Build script relies on svnant,
which is not compatible with subversion 1.5 working copies
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620337#action_12620337 ]
Doug Cutting commented on ZOOKEEPER-110:
----------------------------------------
> The <exec> task will fail on Windows - it won't be able to find the executable "sh.exe".
Hadoop requires cygwin on Windows.
> Build script relies on svnant, which is not compatible with subversion 1.5 working copies
> -----------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-110
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110
> Project: Zookeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.0.0
> Environment: Subversion 1.5 command line, or subclipse version 1.4.x
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: svntask.diff
>
>
> The current build.xml ant script uses svnant to obtain the latest revision number from the repo, however svnant is not compatible with subversion 1.5 (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build fails with working copies checked out by this version. The build fails with "this version of subversion is too old, please get a newer version..." This will become more apparent as svn 1.5 trickles out; I'm using a brand new dev environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather quickly.
> Those with svn 1.5 can get the code from the trunk, but cannot do an ant build.
> svnant hasn't been updated in more than a year and appears to be dead, so it may no longer be a viable tool for the ant build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-110) Build script relies on svnant,
which is not compatible with subversion 1.5 working copies
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620379#action_12620379 ]
Patrick Hunt commented on ZOOKEEPER-110:
----------------------------------------
No worries Jakob, we appreciate your contributions and willingness to work with the community! Honestly I didn't know myself until Owen mentioned it. (that's why we have parental oversight. ;-) ) Regards.
> Build script relies on svnant, which is not compatible with subversion 1.5 working copies
> -----------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-110
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110
> Project: Zookeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.0.0
> Environment: Subversion 1.5 command line, or subclipse version 1.4.x
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: svntask.diff
>
>
> The current build.xml ant script uses svnant to obtain the latest revision number from the repo, however svnant is not compatible with subversion 1.5 (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build fails with working copies checked out by this version. The build fails with "this version of subversion is too old, please get a newer version..." This will become more apparent as svn 1.5 trickles out; I'm using a brand new dev environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather quickly.
> Those with svn 1.5 can get the code from the trunk, but cannot do an ant build.
> svnant hasn't been updated in more than a year and appears to be dead, so it may no longer be a viable tool for the ant build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-110) Build script relies on svnant,
which is not compatible with subversion 1.5 working copies
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620368#action_12620368 ]
Jakob Homan commented on ZOOKEEPER-110:
---------------------------------------
Yes, in the ant exec task you can specify which os the command should run on, so we should be able to write two separate exec tasks: one for win, one for *nix. I'm writing the script for linux now/modifying the buld.xml and will upload the patch in a bit. I can look at how to do it in windows as well, but I'm not sure how to get the info within a good scripting environment. Sorry if it was incorrect to upload the patch that required the bad license. -jg
> Build script relies on svnant, which is not compatible with subversion 1.5 working copies
> -----------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-110
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110
> Project: Zookeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.0.0
> Environment: Subversion 1.5 command line, or subclipse version 1.4.x
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: svntask.diff
>
>
> The current build.xml ant script uses svnant to obtain the latest revision number from the repo, however svnant is not compatible with subversion 1.5 (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build fails with working copies checked out by this version. The build fails with "this version of subversion is too old, please get a newer version..." This will become more apparent as svn 1.5 trickles out; I'm using a brand new dev environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather quickly.
> Those with svn 1.5 can get the code from the trunk, but cannot do an ant build.
> svnant hasn't been updated in more than a year and appears to be dead, so it may no longer be a viable tool for the ant build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-110) Build script relies on svnant,
which is not compatible with subversion 1.5 working copies
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-110:
-----------------------------------
Assignee: Jakob Homan
Status: Open (was: Patch Available)
I'm +1 on this change, -1 on using svntask re the issues Owen mentioned.
Jakob -- notice that Hadoop core does something very similar, however they use a script, could you reuse this rather than relying on a third party library?
http://svn.apache.org/repos/asf/hadoop/core/trunk/build.xml
<exec executable="sh">
<arg line="src/saveVersion.sh ${version}"/>
</exec>
http://svn.apache.org/repos/asf/hadoop/core/trunk/src/saveVersion.sh
> Build script relies on svnant, which is not compatible with subversion 1.5 working copies
> -----------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-110
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110
> Project: Zookeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.0.0
> Environment: Subversion 1.5 command line, or subclipse version 1.4.x
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: svntask.diff
>
>
> The current build.xml ant script uses svnant to obtain the latest revision number from the repo, however svnant is not compatible with subversion 1.5 (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build fails with working copies checked out by this version. The build fails with "this version of subversion is too old, please get a newer version..." This will become more apparent as svn 1.5 trickles out; I'm using a brand new dev environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather quickly.
> Those with svn 1.5 can get the code from the trunk, but cannot do an ant build.
> svnant hasn't been updated in more than a year and appears to be dead, so it may no longer be a viable tool for the ant build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-110) Build script relies on svnant,
which is not compatible with subversion 1.5 working copies
Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jakob Homan updated ZOOKEEPER-110:
----------------------------------
Status: Patch Available (was: Open)
I've modified the build.xml, replacing the previous svnant task with the same functionality using svntask (http://code.google.com/p/svntask/). Svntask is apache-licensed, however, it relies on svnkit, which has an odd dual license (http://svnkit.com/licensing.html). I'm not sure if this will create a licensing issue. Not reflected in the patch is deleting the svnant directory in src/java/lib/ and adding a new directory, src/java/lib/svntask, that includes svnkit.jar and svntask.jar, obtained from the two sites above.
Hope this is useful.
> Build script relies on svnant, which is not compatible with subversion 1.5 working copies
> -----------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-110
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110
> Project: Zookeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.0.0
> Environment: Subversion 1.5 command line, or subclipse version 1.4.x
> Reporter: Jakob Homan
>
> The current build.xml ant script uses svnant to obtain the latest revision number from the repo, however svnant is not compatible with subversion 1.5 (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build fails with working copies checked out by this version. The build fails with "this version of subversion is too old, please get a newer version..." This will become more apparent as svn 1.5 trickles out; I'm using a brand new dev environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather quickly.
> Those with svn 1.5 can get the code from the trunk, but cannot do an ant build.
> svnant hasn't been updated in more than a year and appears to be dead, so it may no longer be a viable tool for the ant build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-110) Build script relies on svnant,
which is not compatible with subversion 1.5 working copies
Posted by "Andrew Kornev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Kornev updated ZOOKEEPER-110:
------------------------------------
Attachment: ZOOKEEPER-110.patch
It turns out that the original patch used the <exec> task attribute "osfamily" that is only available since ant 1.7. This patch ensures that build.xml is compatible with pre-1.7 versions. The apache license headers are also included. Please review. Thanks!
> Build script relies on svnant, which is not compatible with subversion 1.5 working copies
> -----------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-110
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110
> Project: Zookeeper
> Issue Type: Bug
> Components: build
> Affects Versions: 3.0.0
> Environment: Subversion 1.5 command line, or subclipse version 1.4.x
> Reporter: Jakob Homan
> Assignee: Jakob Homan
> Attachments: ZOOKEEPER-110.patch, ZOOKEEPER-110.patch, ZOOKEEPER-110.patch, ZOOKEEPER-110.patch
>
>
> The current build.xml ant script uses svnant to obtain the latest revision number from the repo, however svnant is not compatible with subversion 1.5 (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build fails with working copies checked out by this version. The build fails with "this version of subversion is too old, please get a newer version..." This will become more apparent as svn 1.5 trickles out; I'm using a brand new dev environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather quickly.
> Those with svn 1.5 can get the code from the trunk, but cannot do an ant build.
> svnant hasn't been updated in more than a year and appears to be dead, so it may no longer be a viable tool for the ant build.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.