You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@marvin.apache.org by GitBox <gi...@apache.org> on 2019/11/26 14:57:56 UTC

[GitHub] [incubator-marvin] cardosolucas commented on a change in pull request #37: Bigquery support

cardosolucas commented on a change in pull request #37: Bigquery support
URL: https://github.com/apache/incubator-marvin/pull/37#discussion_r350790844
 
 

 ##########
 File path: python-toolbox/setup.py
 ##########
 @@ -91,9 +93,9 @@
     'pytest>=2.9.2',
     'pytest-cov>=1.8.1,<2.6',
     'pytest-watch>=4.1.0',
-    'pytest-testmon>=0.8.2',
+    'pytest-testmon==0.8.2',
     'Keras>=2.2.0',
-    'tensorflow>=1.8.0',
+    'tensorflow==2.0',
 
 Review comment:
   I agree, the dependency setting was made to fix the keras_serializer test on travis. How do I proceed? Should I create another pull request to set the dependencies version and then merge this one?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services