[jira] [Commented] (LOGCXX-428) Wildcards in Makefile.am break either VPATH or non-VPATH installs

["Rhys Ulerich (JIRA)" <lo...@logging.apache.org>]

    [ https://issues.apache.org/jira/browse/LOGCXX-428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14240699#comment-14240699 ] 

Rhys Ulerich commented on LOGCXX-428:
-------------------------------------

Have been staring at this a bit tonight-- I've got the various wildcards expanded in the various Makefile.am and the usual make check targets seem to work.  Installation works.  I'm hitting a distclean issue on distcheck that I still need to sort through.

> Wildcards in Makefile.am break either VPATH or non-VPATH installs
> -----------------------------------------------------------------
>
>                 Key: LOGCXX-428
>                 URL: https://issues.apache.org/jira/browse/LOGCXX-428
>             Project: Log4cxx
>          Issue Type: Bug
>          Components: Build
>    Affects Versions: 0.11.0
>         Environment: Autoconfiscated builds
>            Reporter: Rhys Ulerich
>            Assignee: Rhys Ulerich
>            Priority: Blocker
>
> The Makefile.am files scattered about the build tree use wildcards (e.g. src/main/include/log4cxx/Makefile.am) which is a no-no (https://www.gnu.org/software/automake/manual/html_node/Wildcards.html).  On a VPATH build, not including $(top_srcdir) and $(top_builddir) when looking for headers with *.h causes generated headers to not be installed (e.g. log4cxx/log4cxx.h!).  On a non-VPATH build, including both causes duplicates in the installed file lists (as $(top_srcdir) and $(top_builddir) coincide) and can break installation a la LOG4CXX-385.
> The Makefile.am files need to include explicit header lists.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)