[GitHub] [rocketmq] joeCarf commented on a diff in pull request #7200: develop proxy language bugfix

["joeCarf (via GitHub)" <gi...@apache.org>]

joeCarf commented on code in PR #7200:
URL: https://github.com/apache/rocketmq/pull/7200#discussion_r1299858906


##########
remoting/src/main/java/org/apache/rocketmq/remoting/protocol/LanguageCode.java:
##########
@@ -50,4 +55,10 @@ public static LanguageCode valueOf(byte code) {
     public byte getCode() {
         return code;
     }
+    
+    

Review Comment:
   redundant line



##########
proxy/src/main/java/org/apache/rocketmq/proxy/service/message/LocalRemotingCommand.java:
##########
@@ -37,4 +40,5 @@ public CommandCustomHeader decodeCommandCustomHeader(
         Class<? extends CommandCustomHeader> classHeader) throws RemotingCommandException {
         return classHeader.cast(readCustomHeader());
     }
+    

Review Comment:
   redundant line



##########
remoting/src/main/java/org/apache/rocketmq/remoting/protocol/LanguageCode.java:
##########
@@ -50,4 +55,10 @@ public static LanguageCode valueOf(byte code) {
     public byte getCode() {
         return code;
     }
+    
+    

Review Comment:
   BTW, I think the pr title can be named like [ISSUE #xxx] Fix: xxxx



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org