You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2022/12/06 16:28:20 UTC

[GitHub] [gobblin] phet commented on pull request #3613: [GOBBLIN-1753] Migrate DB connection pool from o.a.commons.dbcp/dbcp2 to HikariCP

phet commented on PR #3613:
URL: https://github.com/apache/gobblin/pull/3613#issuecomment-1339637044

   > LGTM. Seems like any semantic changes are a result from a difference in API between DBCP and Hikari. and in this case, most of them are non consequential. I have summarized the ones I see below and they all seem reasonable.
   
   yes, I agree w/ your analysis: these generally resulted from a desire to maintain semantics, amidst differences in the two.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org