You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/02/04 19:27:34 UTC

[GitHub] [trafficserver] rob05c opened a new pull request #7483: Fix KA header not checking strategy

rob05c opened a new pull request #7483:
URL: https://github.com/apache/trafficserver/pull/7483


   Fixes handle_request_keep_alive_headers directly checking the old
   parentage for parent_is_proxy, instead of the abstract func which
   checks the strategy if it exists.
   
   This would cause the Connection header to get added instead of the
   correct Proxy-Connection when Strategies are used.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] bryancall commented on pull request #7483: Fix KA header not checking strategy

Posted by GitBox <gi...@apache.org>.
bryancall commented on pull request #7483:
URL: https://github.com/apache/trafficserver/pull/7483#issuecomment-774146901


   [approve ci]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] shinrich merged pull request #7483: Fix KA header not checking strategy

Posted by GitBox <gi...@apache.org>.
shinrich merged pull request #7483:
URL: https://github.com/apache/trafficserver/pull/7483


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] zwoop commented on pull request #7483: Fix KA header not checking strategy

Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #7483:
URL: https://github.com/apache/trafficserver/pull/7483#issuecomment-788137266


   Cherry-picked to v9.0.x branch.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] rob05c commented on pull request #7483: Fix KA header not checking strategy

Posted by GitBox <gi...@apache.org>.
rob05c commented on pull request #7483:
URL: https://github.com/apache/trafficserver/pull/7483#issuecomment-774135659


   We had some discussions about `Proxy-Connection` in Slack. It is Always Wrong for ATS (or anyone) to _send_ Proxy-Connection. Though we should probably use it if we receive it.
   
   I made an issue to track that: https://github.com/apache/trafficserver/issues/7492
   
   But, this still fixes a bug in the logic which will lead to subtle and cryptic bugs, and fixes Strategies and non-Strategies to be consistent.
   
   I think we should merge this for the immediate bug, and then fix 7492 separately.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficserver] zwoop commented on pull request #7483: Fix KA header not checking strategy

Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #7483:
URL: https://github.com/apache/trafficserver/pull/7483#issuecomment-788137521


   Cherry-picked to v9.1.x branch.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org