You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2022/05/06 12:57:22 UTC

[GitHub] [servicecomb-pack] coolbeevip commented on a diff in pull request #757: SCB-2477 Use CI friendly maven version

coolbeevip commented on code in PR #757:
URL: https://github.com/apache/servicecomb-pack/pull/757#discussion_r866800994


##########
pack-dependencies/pom.xml:
##########
@@ -843,4 +843,52 @@
       </dependency>
     </dependencies>
   </dependencyManagement>
+
+  <build>
+    <pluginManagement>
+      <plugins>
+        <plugin>
+          <groupId>org.codehaus.mojo</groupId>
+          <artifactId>flatten-maven-plugin</artifactId>

Review Comment:
   > Could you add some comment on why we introduce the faltten-maven-plugin?
   
   I have added a comment 
   
   > Install or deploy artifacts with Maven CI Friendly Versions https://maven.apache.org/maven-ci-friendly.html#install-deploy



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org