You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2020/04/24 15:29:07 UTC
[Impala-ASF-CR] IMPALA-9677: Fix frontend tests using a non-existent S3 bucket
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15799
Change subject: IMPALA-9677: Fix frontend tests using a non-existent S3 bucket
......................................................................
IMPALA-9677: Fix frontend tests using a non-existent S3 bucket
With HADOOP-16711, Hadoop added extra validation during the
initialization of S3AFileSystem that verified that the caller had
permissions on the S3 bucket specified. Some frontend tests use
non-existent S3 buckets in URIs to check analysis behavior. These
started to fail with the new validation.
This changes the core-site.xml configuration to disable the new
validation by setting fs.s3a.bucket.probe=1. This is equivalent
to the old behavior, and it can now run the frontend tests without
AWS credentials.
Testing:
- Hand tested the failing tests (AnalyzeDDLTest, ExplainTest, PlannerTest)
- Ran core job on USE_CDP_HIVE=true and USE_CDP_HIVE=false
Change-Id: Id61ffbf686f8b7827e7fbf13167cfc1dfc06a325
---
M testdata/cluster/node_templates/common/etc/hadoop/conf/core-site.xml.py
1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/99/15799/1
--
To view, visit http://gerrit.cloudera.org:8080/15799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id61ffbf686f8b7827e7fbf13167cfc1dfc06a325
Gerrit-Change-Number: 15799
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-9677: Fix frontend tests using a non-existent S3 bucket
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/15799 )
Change subject: IMPALA-9677: Fix frontend tests using a non-existent S3 bucket
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15799/1/testdata/cluster/node_templates/common/etc/hadoop/conf/core-site.xml.py
File testdata/cluster/node_templates/common/etc/hadoop/conf/core-site.xml.py:
http://gerrit.cloudera.org:8080/#/c/15799/1/testdata/cluster/node_templates/common/etc/hadoop/conf/core-site.xml.py@114
PS1, Line 114: use_cdp_components:
> Does setting USE_CDP_HIVE=true also change Hadoop version?
Yes, it ended up controlling all the components, not just Hive. We need to rename it or get rid of that environment variable.
--
To view, visit http://gerrit.cloudera.org:8080/15799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id61ffbf686f8b7827e7fbf13167cfc1dfc06a325
Gerrit-Change-Number: 15799
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 24 Apr 2020 16:44:18 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9677: Fix frontend tests using a non-existent S3 bucket
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15799 )
Change subject: IMPALA-9677: Fix frontend tests using a non-existent S3 bucket
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5870/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id61ffbf686f8b7827e7fbf13167cfc1dfc06a325
Gerrit-Change-Number: 15799
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 24 Apr 2020 16:10:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9677: Fix frontend tests using a non-existent S3 bucket
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15799 )
Change subject: IMPALA-9677: Fix frontend tests using a non-existent S3 bucket
......................................................................
IMPALA-9677: Fix frontend tests using a non-existent S3 bucket
With HADOOP-16711, Hadoop added extra validation during the
initialization of S3AFileSystem that verified that the caller had
permissions on the S3 bucket specified. Some frontend tests use
non-existent S3 buckets in URIs to check analysis behavior. These
started to fail with the new validation.
This changes the core-site.xml configuration to disable the new
validation by setting fs.s3a.bucket.probe=1. This is equivalent
to the old behavior, and it can now run the frontend tests without
AWS credentials.
Testing:
- Hand tested the failing tests (AnalyzeDDLTest, ExplainTest, PlannerTest)
- Ran core job on USE_CDP_HIVE=true and USE_CDP_HIVE=false
Change-Id: Id61ffbf686f8b7827e7fbf13167cfc1dfc06a325
Reviewed-on: http://gerrit.cloudera.org:8080/15799
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Anurag Mantripragada <an...@cloudera.com>
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
---
M testdata/cluster/node_templates/common/etc/hadoop/conf/core-site.xml.py
1 file changed, 8 insertions(+), 0 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Anurag Mantripragada: Looks good to me, but someone else must approve
Tim Armstrong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/15799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id61ffbf686f8b7827e7fbf13167cfc1dfc06a325
Gerrit-Change-Number: 15799
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-9677: Fix frontend tests using a non-existent S3 bucket
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15799 )
Change subject: IMPALA-9677: Fix frontend tests using a non-existent S3 bucket
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id61ffbf686f8b7827e7fbf13167cfc1dfc06a325
Gerrit-Change-Number: 15799
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 24 Apr 2020 16:43:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9677: Fix frontend tests using a non-existent S3 bucket
Posted by "Anurag Mantripragada (Code Review)" <ge...@cloudera.org>.
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15799 )
Change subject: IMPALA-9677: Fix frontend tests using a non-existent S3 bucket
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Looks good to me.
http://gerrit.cloudera.org:8080/#/c/15799/1/testdata/cluster/node_templates/common/etc/hadoop/conf/core-site.xml.py
File testdata/cluster/node_templates/common/etc/hadoop/conf/core-site.xml.py:
http://gerrit.cloudera.org:8080/#/c/15799/1/testdata/cluster/node_templates/common/etc/hadoop/conf/core-site.xml.py@114
PS1, Line 114: use_cdp_components:
Does setting USE_CDP_HIVE=true also change Hadoop version?
--
To view, visit http://gerrit.cloudera.org:8080/15799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id61ffbf686f8b7827e7fbf13167cfc1dfc06a325
Gerrit-Change-Number: 15799
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 24 Apr 2020 16:42:46 +0000
Gerrit-HasComments: Yes