You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "simbit18 (via GitHub)" <gi...@apache.org> on 2023/05/15 09:31:15 UTC

[GitHub] [nuttx] simbit18 opened a new pull request, #9280: arch/arm/src/stm32h7/stm32_usbhost.c: Fix nxstyle errors

simbit18 opened a new pull request, #9280:
URL: https://github.com/apache/nuttx/pull/9280

   ## Summary
   error: Long line found
   ## Impact
   none
   ## Testing
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] simbit18 commented on pull request #9280: arch/arm/src/stm32h7/stm32_usbhost.c: Fix nxstyle errors

Posted by "simbit18 (via GitHub)" <gi...@apache.org>.
simbit18 commented on PR #9280:
URL: https://github.com/apache/nuttx/pull/9280#issuecomment-1547994956

   > @simbit18
   > 
   > Are you aware that the initial comment line sets the the "Ruler" and then lines can be longer?
   Yes
   
   
   Hi @davids5,   
   I just changed it this way to keep it consistent with the approach already established in other files.
   https://github.com/apache/nuttx/blob/master/arch/arm/src/efm32/efm32_usbhost.c
   https://github.com/apache/nuttx/blob/master/arch/arm/src/imxrt/imxrt_ehci.c
   https://github.com/apache/nuttx/blob/master/arch/arm/src/kinetis/kinetis_usbhshost.c
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] davids5 commented on pull request #9280: arch/arm/src/stm32h7/stm32_usbhost.c: Fix nxstyle errors

Posted by "davids5 (via GitHub)" <gi...@apache.org>.
davids5 commented on PR #9280:
URL: https://github.com/apache/nuttx/pull/9280#issuecomment-1547612583

   @simbit18 
   
   Are you aware that the initial comment line sets the the "Ruler" and then lines can be longer? 
   
   This change makes the file less readable. I would not support merging it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] xiaoxiang781216 merged pull request #9280: arch/arm/src/stm32h7/stm32_usbhost.c: Fix nxstyle errors

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #9280:
URL: https://github.com/apache/nuttx/pull/9280


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org