[GitHub] [flink] klion26 commented on a change in pull request #10824: [FLINK-15152][checkpointing] Restatrt CheckpointCoordinator if StopWithSavepoint failed

[GitBox <gi...@apache.org>]

klion26 commented on a change in pull request #10824: [FLINK-15152][checkpointing] Restatrt CheckpointCoordinator if StopWithSavepoint failed
URL: https://github.com/apache/flink/pull/10824#discussion_r367226527
 
 

 ##########
 File path: flink-tests/src/test/java/org/apache/flink/runtime/jobmaster/JobMasterStopWithSavepointIT.java
 ##########
 @@ -357,4 +391,36 @@ public void finishTask() throws Exception {
 			finishLatch.trigger();
 		}
 	}
+
+	/**
+	 * A {@link StreamTask} that simply calls {@link CountDownLatch#countDown()} when
+	 * invoking {@link #triggerCheckpointAsync}.
+	 */
+	public static class CheckpointCountingTask extends NoOpStreamTask {
 
 Review comment:
   Ok, will update it. previously did not change to this, because I though in `CheckpointCountingTask` we do not need to distinguish whether this task is in subtask 0 (and can tolerate some code dup in test), but distinguish whether this task is subtask 0 seems has no side effect.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services