You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/28 12:08:07 UTC

[GitHub] [incubator-superset] villebro opened a new pull request #9669: fix: refine viz exception handling

villebro opened a new pull request #9669:
URL: https://github.com/apache/incubator-superset/pull/9669


   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   Currently form data validation are raised as `Exception` and aren't being caught in Flask views, causing uncaught application errors and false positives in error monitoring frameworks. This PR changes form validation exceptions in `viz.py` to `QueryObjectValidationError`-type exceptions (extends `SupersetException`), and catches them in the relevant Flask views. Application errors will not be caught in the views, ensuring that critical errors are still caught on error logs.
   
   ### TEST PLAN
   Local testing + CI
   
   ### REVIEWERS
   @willbarrett 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org