[jira] [Commented] (RAVE-392) Use JPA instead of SQL statements for data initialization

["marijan milicevic (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/RAVE-392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13181988#comment-13181988 ] 

marijan milicevic commented on RAVE-392:
----------------------------------------

Hi Jesse,

thanks for your reply. I am curious about the reasons against it (maybe some digging on mailing list will help, I'll try that).

Could someone shed some light on my second question:

"I am not sure why rave-commons is not part of rave-core (as a subpackage) because it only contains handful of classes which are mostly used within rave-core itself and both of those dependencies are included as dependencies of other sub-projects "

btw: " both of those dependencies are included as dependencies of other sub-projects"
means:

they are never used separately, always combination of both.



                
> Use JPA instead of SQL statements for data initialization
> ---------------------------------------------------------
>
>                 Key: RAVE-392
>                 URL: https://issues.apache.org/jira/browse/RAVE-392
>             Project: Rave
>          Issue Type: Improvement
>    Affects Versions: 0.7-INCUBATING
>            Reporter: marijan milicevic
>         Attachments: jpa_data_initialization_.patch
>
>
> please see attached patch and test case as an example. I think most of the data inserted is same to data inserted by init_data.sql file, except for the user layout (all users have same layout) 
> Motivation:
> - this should work on any database
> - it is easier to maintain (for most part you have type safety, renaming, test cases if needed)
> - it is easier to split/extend/modify by users
> Problem: 
> - in current setup it is not easy to use above initializing because data initializing/wiring  is done in rave-commons and above class depends on rave-core. I am not sure why rave-commons is not part of rave-core (as a subpackage) because it only contains handful of classes which are mostly used within rave-core itself and both of those dependencies are included as dependencies of other sub-projects

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira