[GitHub] [incubator-shardingsphere] Saisimon commented on issue #2604: The query entity throws an exception when a boolean property exists in the entity

[GitBox <gi...@apache.org>]

Saisimon commented on issue #2604: The query entity throws an exception when a boolean property exists in the entity
URL: https://github.com/apache/incubator-shardingsphere/issues/2604#issuecomment-505736945
 
 
   The ResultSetUtil#convertByteArrayValue method references to MySQL JDBC driver 5.1 version, it just checks first of byte array.In 8.0 version, it changes to byte array -> long -> boolean, you can find the implement in [here](https://github.com/mysql/mysql-connector-j/blob/release/8.0/src/main/core-impl/java/com/mysql/cj/result/BooleanValueFactory.java#L78), I’m not sure which way is better, what do you think? BTW, this method has only been verified in the MySQL database, I don't have an environment for other databases.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services