You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "jerqi (via GitHub)" <gi...@apache.org> on 2023/08/21 07:50:24 UTC
[GitHub] [iceberg] jerqi commented on a diff in pull request #8336: Core: Optimize offset splits handling
jerqi commented on code in PR #8336:
URL: https://github.com/apache/iceberg/pull/8336#discussion_r1299734411
##########
core/src/main/java/org/apache/iceberg/util/ArrayUtil.java:
##########
@@ -300,4 +310,14 @@ private static Object copyArrayGrow1(final Object array, final Class<?> newArray
}
return Array.newInstance(newArrayComponentType, 1);
}
+
+ public static boolean isStrictlyOrdered(long[] array) {
+ for (int index = 1; index < array.length; index++) {
Review Comment:
This method only returns true when the array is strictly ascending ordered. It will return false when the array is strictly descending ordered.
Maybe `isStrictlyAscendingOrdered` is a better method. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org