[GitHub] [arrow] eerhardt commented on a diff in pull request #35996: GH-35988: [C#] The C data interface implementation can leak on import

["eerhardt (via GitHub)" <gi...@apache.org>]

eerhardt commented on code in PR #35996:
URL: https://github.com/apache/arrow/pull/35996#discussion_r1223154468


##########
csharp/src/Apache.Arrow/C/CArrowArrayImporter.cs:
##########
@@ -42,12 +43,12 @@ public static class CArrowArrayImporter
         /// IArrowArray importedArray = CArrowArrayImporter.ImportArray(importedPtr);
         /// </code>
         /// </examples>
-        public static unsafe IArrowArray ImportArray(CArrowArray* ptr, IArrowType type)
+        public static unsafe IArrowArray ImportArray(CArrowArray* ptr, IArrowType type, bool freeOnRelease)

Review Comment:
   Should `freeOnRelease` have a default value? Or is it imperative that the caller sets it?



##########
csharp/src/Apache.Arrow/C/CArrowArrayImporter.cs:
##########
@@ -29,7 +29,8 @@ public static class CArrowArrayImporter
         /// </summary>
         /// <remarks>
         /// This will call the release callback once all of the buffers in the returned
-        /// IArrowArray are disposed.
+        /// IArrowArray are disposed. If freeOnRelease is set, it will also free the memory

Review Comment:
   Usually comments about the parameters go in a `/// <param name="name">` comment.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org