You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/02/08 06:36:32 UTC
[GitHub] [iotdb] CloudWise-Lukemiao opened a new pull request #5017: [IOTDB-2518] fixed grafana plugin not support microsecond or nanosecond
CloudWise-Lukemiao opened a new pull request #5017:
URL: https://github.com/apache/iotdb/pull/5017
[IOTDB-2518] fixed grafana plugin not support microsecond or nanosecond
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SteveYurongSu commented on a change in pull request #5017: [IOTDB-2518] fixed grafana plugin not support microsecond or nanosecond
Posted by GitBox <gi...@apache.org>.
SteveYurongSu commented on a change in pull request #5017:
URL: https://github.com/apache/iotdb/pull/5017#discussion_r801494943
##########
File path: server/src/main/java/org/apache/iotdb/db/protocol/rest/handler/QueryDataSetHandler.java
##########
@@ -213,7 +231,10 @@ private static Response fillQueryDataSetWithTimestamps(
}
RowRecord sourceDataSetRowRecord = sourceDataSet.next();
- targetDataSet.addTimestampsItem(sourceDataSetRowRecord.getTimestamp());
+ targetDataSet.addTimestampsItem(
+ timePrecision == 1
Review comment:
Can be simplifed to sourceDataSetRowRecord.getTimestamp() / timePrecision
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SteveYurongSu merged pull request #5017: [IOTDB-2518] fixed grafana plugin not support microsecond or nanosecond
Posted by GitBox <gi...@apache.org>.
SteveYurongSu merged pull request #5017:
URL: https://github.com/apache/iotdb/pull/5017
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls commented on pull request #5017: [IOTDB-2518] fixed grafana plugin not support microsecond or nanosecond
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #5017:
URL: https://github.com/apache/iotdb/pull/5017#issuecomment-1032296833
[](https://coveralls.io/builds/46321514)
Coverage increased (+0.02%) to 67.765% when pulling **ad7f79ae39464664c6043b69ffaa117d44e3d08b on CloudWise-Lukemiao:fixed_IOTDB_2518** into **5767587be65982056e87f0a08552601f4b8d0583 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org