You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/08/29 08:51:19 UTC

[GitHub] [spark] dbtsai edited a comment on pull request #29567: [SPARK-32721][SQL] Simplify if clauses with null and boolean

dbtsai edited a comment on pull request #29567:
URL: https://github.com/apache/spark/pull/29567#issuecomment-683259420


   This will be a very useful optimization to turn `if causes` into expressions that can be pushdown. For `CaseWhen` if there is only one branch, we can convert it into `If`. A PR awhile ago https://github.com/apache/spark/pull/21850 implemented this optimization but didn't end up merging into master because at that time, `CaseWhen` and `If` have not much performance difference. Maybe we can revisit that again.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org