You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/15 07:33:42 UTC

[GitHub] [airflow] uranusjr commented on a change in pull request #20291: Fix mypy for exasol and facebook hooks

uranusjr commented on a change in pull request #20291:
URL: https://github.com/apache/airflow/pull/20291#discussion_r769329573



##########
File path: airflow/providers/exasol/hooks/exasol.py
##########
@@ -143,7 +143,9 @@ def export_to_file(
             )
         self.log.info("Data saved to %s", filename)
 
-    def run(self, sql: Union[str, list], autocommit: bool = False, parameters: Optional[dict] = None) -> None:
+    def run(
+        self, sql: Union[str, list], autocommit: bool = False, parameters: Optional[dict] = None, handler=None

Review comment:
       Let’s make `sql` a `Union[str, List[str]]`.
   
   Why is `handler` added?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org