[GitHub] [trafficserver] cmcfarlen commented on a diff in pull request #9424: combine UDPPacket and UDPPacketInternal

["cmcfarlen (via GitHub)" <gi...@apache.org>]

cmcfarlen commented on code in PR #9424:
URL: https://github.com/apache/trafficserver/pull/9424#discussion_r1108764514


##########
iocore/net/I_UDPConnection.h:
##########
@@ -100,6 +100,15 @@ class UDPConnection : public Continuation
   void bindToThread(Continuation *c, EThread *t);
 
   virtual void UDPConnection_is_abstract() = 0;
+
+  // this is for doing packet scheduling: we keep two values so that we can
+  // implement cancel.  The first value tracks the startTime of the last
+  // packet that was sent on this connection; the second value tracks the
+  // startTime of the last packet when we are doing scheduling;  whenever the
+  // associated continuation cancels a packet, we rest lastPktStartTime to be
+  // the same as the lastSentPktStartTime.
+  uint64_t lastSentPktStartTime = 0;
+  uint64_t lastPktStartTime     = 0;

Review Comment:
   This was moved from UDPConnectionInternal to avoid having the Internal class in UDPPacket.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org