You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@weex.apache.org by wispy316 <gi...@git.apache.org> on 2017/08/14 07:37:12 UTC

[GitHub] incubator-weex pull request #597: Bugfix js storage

GitHub user wispy316 opened a pull request:

    https://github.com/apache/incubator-weex/pull/597

    Bugfix js storage

    html fix storage module setItem not support value = 0

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wispy316/incubator-weex bugfix-js-storage2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-weex/pull/597.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #597
    
----
commit 594d8302cf14c65aa951ee15c5f916cab10bff33
Author: 行久 <yi...@alibaba-inc.com>
Date:   2017-08-11T05:55:13Z

    [html5] fix setItem cannot set value to 0 bug.  https://aone.alibaba-inc.com/issue/12020693

commit c1ae868bd055de2f1f25515cf1e0e79a335fe10a
Author: 行久 <yi...@alibaba-inc.com>
Date:   2017-08-11T06:33:30Z

    [html5] !== lint

commit c01f87d130770f08b48361317a73b885fdfb030b
Author: 行久 <yi...@alibaba-inc.com>
Date:   2017-08-14T06:20:48Z

    [html5] commit update. and fire CI run again. @notdanger

commit 1c3b169cf02ba97630c6b3d34323b16393af50de
Author: 行久 <yi...@alibaba-inc.com>
Date:   2017-08-14T07:35:28Z

    [html5]  fix storage setItem can`t support 0 bug.   @notdanger

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex issue #597: Bugfix js storage

Posted by wispy316 <gi...@git.apache.org>.

Github user wispy316 commented on the issue:

    https://github.com/apache/incubator-weex/pull/597
  
    same as #592 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex issue #597: Bugfix js storage

Posted by weex-bot <gi...@git.apache.org>.

Github user weex-bot commented on the issue:

    https://github.com/apache/incubator-weex/pull/597
  
    
    <!--
      0 failure: 
      3 warning:  No Changelog chan..., This PR modify SD..., This PR should up...
      1 messages
      
    -->
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Warnings</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:warning:</td>
          <td>No Changelog changes!</td>
        </tr>
      
    <tr>
          <td>:warning:</td>
          <td>This PR modify SDK code without add/modify testcases.</td>
        </tr>
      
    <tr>
          <td>:warning:</td>
          <td>This PR should update related documents as well. </td>
        </tr>
      </tbody>
    </table>
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Messages</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:book:</td>
          <td>According to the blame info, we recommended @MrRaindrop to be the reviewers.</td>
        </tr>
      </tbody>
    </table>
    
    
    <p align="right">
      Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
    </p>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex pull request #597: Bugfix js storage

Posted by wispy316 <gi...@git.apache.org>.

Github user wispy316 closed the pull request at:

    https://github.com/apache/incubator-weex/pull/597


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---