You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by prabhjyotsingh <gi...@git.apache.org> on 2018/01/09 07:55:24 UTC

[GitHub] zeppelin pull request #2721: ZEPPELIN-3129: Zepplin UI Doesnt logs out in IE

GitHub user prabhjyotsingh opened a pull request:

    https://github.com/apache/zeppelin/pull/2721

    ZEPPELIN-3129: Zepplin UI Doesnt logs out in IE

    ### What is this PR for?
    Zepplin UI Doesn't logs out in IE/Edge, its Shows Logout Success and automatically reload the page 
    But the User is still logged in. 
    
    This happens when shiro is configured with "authc" however it works for "authcBasic".
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### What is the Jira issue?
    * [ZEPPELIN-3129](https://issues.apache.org/jira/browse/ZEPPELIN-3129)
    
    ### How should this be tested?
    * Logout should work for all browsers and for both shiro configuration i.e. "authc" and "authcBasic"
    
    
    ### Questions:
    * Does the licenses files need update? N/A
    * Is there breaking changes for older versions? N/A
    * Does this needs documentation? N/A


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-3129

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2721.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2721
    
----
commit a9f933c5032d2cff0490a60ccce9ffcdce66c44d
Author: Prabhjyot Singh <pr...@...>
Date:   2018-01-09T07:51:51Z

    ZEPPELIN-3129: Zepplin UI Doesnt logs out in IE

----


---

[GitHub] zeppelin issue #2721: [ZEPPELIN-3129] Zepplin UI Doesnt logs out in IE

Posted by Akhilsnaik <gi...@git.apache.org>.

Github user Akhilsnaik commented on the issue:

    https://github.com/apache/zeppelin/pull/2721
  
    Have Tested in Windows 7 IE 11 , 
    The Fix works fine in IE 11. 
    



---

[GitHub] zeppelin pull request #2721: [ZEPPELIN-3129] Zepplin UI Doesnt logs out in I...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2721


---

[GitHub] zeppelin issue #2721: [ZEPPELIN-3129] Zepplin UI Doesnt logs out in IE

Posted by prabhjyotsingh <gi...@git.apache.org>.

Github user prabhjyotsingh commented on the issue:

    https://github.com/apache/zeppelin/pull/2721
  
    Have tested this for FF31, FF57, Chrome-63, Safari-11, Windows7's IE-12 and Windows10's Edge-25


---

[GitHub] zeppelin issue #2721: [ZEPPELIN-3129] Zepplin UI Doesnt logs out in IE

Posted by prabhjyotsingh <gi...@git.apache.org>.

Github user prabhjyotsingh commented on the issue:

    https://github.com/apache/zeppelin/pull/2721
  
    Thanks for the review will merge this if no more discussion.


---