You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by michael goulish <mg...@redhat.com> on 2015/06/19 20:10:13 UTC
Review Request 35658: Fix the java tests that my previous checkin
broke.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35658/
-----------------------------------------------------------
Review request for qpid, Kenneth Giusti and Ted Ross.
Repository: qpid-proton-git
Description
-------
Fix the java tests that my previous checkin broke. Also implement the logic (in the Java impl) to prevent channel_max from being changed by the application after the OPEN frame has been sent (because at that time we tell the remote peer what our channel_max is).
Diffs
-----
proton-j/src/main/java/org/apache/qpid/proton/engine/impl/TransportImpl.java a5c8ba9
tests/python/proton_tests/engine.py e3258a2
Diff: https://reviews.apache.org/r/35658/diff/
Testing
-------
ctest -VV
Thanks,
michael goulish
Re: Review Request 35658: Fix the java tests that my previous checkin
broke.
Posted by Kenneth Giusti <kg...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35658/#review88567
-----------------------------------------------------------
Ship it!
Ship It!
- Kenneth Giusti
On June 19, 2015, 6:10 p.m., michael goulish wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35658/
> -----------------------------------------------------------
>
> (Updated June 19, 2015, 6:10 p.m.)
>
>
> Review request for qpid, Kenneth Giusti and Ted Ross.
>
>
> Repository: qpid-proton-git
>
>
> Description
> -------
>
> Fix the java tests that my previous checkin broke. Also implement the logic (in the Java impl) to prevent channel_max from being changed by the application after the OPEN frame has been sent (because at that time we tell the remote peer what our channel_max is).
>
>
> Diffs
> -----
>
> proton-j/src/main/java/org/apache/qpid/proton/engine/impl/TransportImpl.java a5c8ba9
> tests/python/proton_tests/engine.py e3258a2
>
> Diff: https://reviews.apache.org/r/35658/diff/
>
>
> Testing
> -------
>
> ctest -VV
>
>
> Thanks,
>
> michael goulish
>
>
Re: Review Request 35658: Fix the java tests that my previous checkin
broke.
Posted by Kenneth Giusti <kg...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35658/#review88566
-----------------------------------------------------------
tests/python/proton_tests/engine.py (line 253)
<https://reviews.apache.org/r/35658/#comment141144>
This is interesting. We could get the C impl to act the same way by having the python binding raise the exception for us.
except that the C impl doesn't return a failure status. Bleh.
hmmmm... I wonder if it should...
BTW: can you add Robbie to the reviewer's list? He's my java goto guy.
- Kenneth Giusti
On June 19, 2015, 6:10 p.m., michael goulish wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35658/
> -----------------------------------------------------------
>
> (Updated June 19, 2015, 6:10 p.m.)
>
>
> Review request for qpid, Kenneth Giusti and Ted Ross.
>
>
> Repository: qpid-proton-git
>
>
> Description
> -------
>
> Fix the java tests that my previous checkin broke. Also implement the logic (in the Java impl) to prevent channel_max from being changed by the application after the OPEN frame has been sent (because at that time we tell the remote peer what our channel_max is).
>
>
> Diffs
> -----
>
> proton-j/src/main/java/org/apache/qpid/proton/engine/impl/TransportImpl.java a5c8ba9
> tests/python/proton_tests/engine.py e3258a2
>
> Diff: https://reviews.apache.org/r/35658/diff/
>
>
> Testing
> -------
>
> ctest -VV
>
>
> Thanks,
>
> michael goulish
>
>