You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "John Sherman (Code Review)" <ge...@cloudera.org> on 2023/02/24 21:52:28 UTC

[Impala-ASF-CR] IMPALA-11946: Add Thrift HTTP support for external frontend

John Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19537


Change subject: IMPALA-11946: Add Thrift HTTP support for external frontend
......................................................................

IMPALA-11946: Add Thrift HTTP support for external frontend

- Add enable_external_fe_http flag that defaults to false
  - When true the external frontend service (external_fe_port) will
  expect clients to use http transport.
  - When false the external frontend service will expect binary
  transport.

- Add tests for basic external frontend functionality
- Add test to ensure the non-external frontend services do not expose
  the ExecutePlannedStatement interface.

Change-Id: I2ad400b1df471e3d61b62d8c0360b27396c26050
---
M be/src/service/impala-server.cc
M fe/src/test/java/org/apache/impala/customcluster/CustomClusterRunner.java
A fe/src/test/java/org/apache/impala/customcluster/ExternalFrontendTest.java
3 files changed, 208 insertions(+), 7 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/37/19537/1
-- 
To view, visit http://gerrit.cloudera.org:8080/19537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2ad400b1df471e3d61b62d8c0360b27396c26050
Gerrit-Change-Number: 19537
Gerrit-PatchSet: 1
Gerrit-Owner: John Sherman <jf...@cloudera.com>

[Impala-ASF-CR] IMPALA-11946: Add Thrift HTTP support for external frontend

Posted by "Aman Sinha (Code Review)" <ge...@cloudera.org>.
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/19537 )

Change subject: IMPALA-11946: Add Thrift HTTP support for external frontend
......................................................................


Patch Set 2: Code-Review+1

(2 comments)

It would be a useful enhancement.  Code changes LGTM (couple of nits).  Any thoughts on the potential performance latency comparison HTTP is used vs binary ? I assume there are existing thrift-over-http vs thrift-over-binary published benchmarks.

http://gerrit.cloudera.org:8080/#/c/19537/2/fe/src/test/java/org/apache/impala/customcluster/ExternalFrontendTest.java
File fe/src/test/java/org/apache/impala/customcluster/ExternalFrontendTest.java:

http://gerrit.cloudera.org:8080/#/c/19537/2/fe/src/test/java/org/apache/impala/customcluster/ExternalFrontendTest.java@22
PS2, Line 22: import org.apache.hive.service.rpc.thrift.*;
nit: I think the wildcard is not allowed for imports.


http://gerrit.cloudera.org:8080/#/c/19537/2/fe/src/test/java/org/apache/impala/customcluster/ExternalFrontendTest.java@46
PS2, Line 46: hs2Port
nit: maybe call this hs2BinaryPort to easily distinguish with the other one.



-- 
To view, visit http://gerrit.cloudera.org:8080/19537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ad400b1df471e3d61b62d8c0360b27396c26050
Gerrit-Change-Number: 19537
Gerrit-PatchSet: 2
Gerrit-Owner: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Mar 2023 20:37:31 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11946: Add Thrift HTTP support for external frontend

Posted by "Aman Sinha (Code Review)" <ge...@cloudera.org>.
Aman Sinha has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19537 )

Change subject: IMPALA-11946: Add Thrift HTTP support for external frontend
......................................................................

IMPALA-11946: Add Thrift HTTP support for external frontend

- Add enable_external_fe_http flag that defaults to false
  - When true the external frontend service (external_fe_port) will
  expect clients to use http transport.
  - When false the external frontend service will expect binary
  transport.

- Add tests for basic external frontend functionality
- Add test to ensure the non-external frontend services do not expose
  the ExecutePlannedStatement interface.

Change-Id: I2ad400b1df471e3d61b62d8c0360b27396c26050
Reviewed-on: http://gerrit.cloudera.org:8080/19537
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Aman Sinha <am...@cloudera.com>
---
M be/src/service/impala-server.cc
M fe/src/test/java/org/apache/impala/customcluster/CustomClusterRunner.java
A fe/src/test/java/org/apache/impala/customcluster/ExternalFrontendTest.java
3 files changed, 220 insertions(+), 7 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Aman Sinha: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/19537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2ad400b1df471e3d61b62d8c0360b27396c26050
Gerrit-Change-Number: 19537
Gerrit-PatchSet: 6
Gerrit-Owner: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>

[Impala-ASF-CR] IMPALA-11946: Add Thrift HTTP support for external frontend

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19537 )

Change subject: IMPALA-11946: Add Thrift HTTP support for external frontend
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/12440/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/19537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ad400b1df471e3d61b62d8c0360b27396c26050
Gerrit-Change-Number: 19537
Gerrit-PatchSet: 1
Gerrit-Owner: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 24 Feb 2023 22:13:34 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11946: Add Thrift HTTP support for external frontend

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19537 )

Change subject: IMPALA-11946: Add Thrift HTTP support for external frontend
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9120/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/19537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ad400b1df471e3d61b62d8c0360b27396c26050
Gerrit-Change-Number: 19537
Gerrit-PatchSet: 4
Gerrit-Owner: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Mar 2023 22:11:41 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11946: Add Thrift HTTP support for external frontend

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19537 )

Change subject: IMPALA-11946: Add Thrift HTTP support for external frontend
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/12556/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/19537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ad400b1df471e3d61b62d8c0360b27396c26050
Gerrit-Change-Number: 19537
Gerrit-PatchSet: 3
Gerrit-Owner: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Mar 2023 22:31:51 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11946: Add Thrift HTTP support for external frontend

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19537 )

Change subject: IMPALA-11946: Add Thrift HTTP support for external frontend
......................................................................


Patch Set 5: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/19537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ad400b1df471e3d61b62d8c0360b27396c26050
Gerrit-Change-Number: 19537
Gerrit-PatchSet: 5
Gerrit-Owner: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Comment-Date: Thu, 09 Mar 2023 01:19:41 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11946: Add Thrift HTTP support for external frontend

Posted by "John Sherman (Code Review)" <ge...@cloudera.org>.
John Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19537 )

Change subject: IMPALA-11946: Add Thrift HTTP support for external frontend
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19537/2/fe/src/test/java/org/apache/impala/customcluster/ExternalFrontendTest.java
File fe/src/test/java/org/apache/impala/customcluster/ExternalFrontendTest.java:

http://gerrit.cloudera.org:8080/#/c/19537/2/fe/src/test/java/org/apache/impala/customcluster/ExternalFrontendTest.java@22
PS2, Line 22: import org.apache.hive.service.rpc.thrift.*;
> nit: I think the wildcard is not allowed for imports.
I can change, but it does match the test I used for a guideline.
fe/src/test/java/org/apache/impala/customcluster/JwtHttpTest.java:import org.apache.hive.service.rpc.thrift.*;
fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java:import org.apache.hive.service.rpc.thrift.*;
fe/src/test/java/org/apache/impala/customcluster/LdapWebserverTest.java:import org.apache.hive.service.rpc.thrift.*;



-- 
To view, visit http://gerrit.cloudera.org:8080/19537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ad400b1df471e3d61b62d8c0360b27396c26050
Gerrit-Change-Number: 19537
Gerrit-PatchSet: 2
Gerrit-Owner: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Mar 2023 21:22:13 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11946: Add Thrift HTTP support for external frontend

Posted by "Aman Sinha (Code Review)" <ge...@cloudera.org>.
Aman Sinha has removed a vote on this change.

Change subject: IMPALA-11946: Add Thrift HTTP support for external frontend
......................................................................


Removed Verified-1 by Impala Public Jenkins <im...@cloudera.com>
-- 
To view, visit http://gerrit.cloudera.org:8080/19537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I2ad400b1df471e3d61b62d8c0360b27396c26050
Gerrit-Change-Number: 19537
Gerrit-PatchSet: 4
Gerrit-Owner: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>

[Impala-ASF-CR] IMPALA-11946: Add Thrift HTTP support for external frontend

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19537 )

Change subject: IMPALA-11946: Add Thrift HTTP support for external frontend
......................................................................


Patch Set 5:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9124/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/19537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ad400b1df471e3d61b62d8c0360b27396c26050
Gerrit-Change-Number: 19537
Gerrit-PatchSet: 5
Gerrit-Owner: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Mar 2023 20:08:04 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11946: Add Thrift HTTP support for external frontend

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19537 )

Change subject: IMPALA-11946: Add Thrift HTTP support for external frontend
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/12460/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/19537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ad400b1df471e3d61b62d8c0360b27396c26050
Gerrit-Change-Number: 19537
Gerrit-PatchSet: 2
Gerrit-Owner: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 27 Feb 2023 18:35:21 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11946: Add Thrift HTTP support for external frontend

Posted by "Aman Sinha (Code Review)" <ge...@cloudera.org>.
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/19537 )

Change subject: IMPALA-11946: Add Thrift HTTP support for external frontend
......................................................................


Patch Set 4: Verified+1

The 2 test failures in the first run are known flaky tests. The re-triggered run https://jenkins.impala.io/job/ubuntu-16.04-dockerised-tests/7105/. was successful.


-- 
To view, visit http://gerrit.cloudera.org:8080/19537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ad400b1df471e3d61b62d8c0360b27396c26050
Gerrit-Change-Number: 19537
Gerrit-PatchSet: 4
Gerrit-Owner: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Mar 2023 20:04:47 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11946: Add Thrift HTTP support for external frontend

Posted by "John Sherman (Code Review)" <ge...@cloudera.org>.
Hello Aman Sinha, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19537

to look at the new patch set (#3).

Change subject: IMPALA-11946: Add Thrift HTTP support for external frontend
......................................................................

IMPALA-11946: Add Thrift HTTP support for external frontend

- Add enable_external_fe_http flag that defaults to false
  - When true the external frontend service (external_fe_port) will
  expect clients to use http transport.
  - When false the external frontend service will expect binary
  transport.

- Add tests for basic external frontend functionality
- Add test to ensure the non-external frontend services do not expose
  the ExecutePlannedStatement interface.

Change-Id: I2ad400b1df471e3d61b62d8c0360b27396c26050
---
M be/src/service/impala-server.cc
M fe/src/test/java/org/apache/impala/customcluster/CustomClusterRunner.java
A fe/src/test/java/org/apache/impala/customcluster/ExternalFrontendTest.java
3 files changed, 220 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/37/19537/3
-- 
To view, visit http://gerrit.cloudera.org:8080/19537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2ad400b1df471e3d61b62d8c0360b27396c26050
Gerrit-Change-Number: 19537
Gerrit-PatchSet: 3
Gerrit-Owner: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>

[Impala-ASF-CR] IMPALA-11946: Add Thrift HTTP support for external frontend

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19537 )

Change subject: IMPALA-11946: Add Thrift HTTP support for external frontend
......................................................................


Patch Set 4: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9120/


-- 
To view, visit http://gerrit.cloudera.org:8080/19537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ad400b1df471e3d61b62d8c0360b27396c26050
Gerrit-Change-Number: 19537
Gerrit-PatchSet: 4
Gerrit-Owner: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Mar 2023 03:21:37 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11946: Add Thrift HTTP support for external frontend

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19537 )

Change subject: IMPALA-11946: Add Thrift HTTP support for external frontend
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/19537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ad400b1df471e3d61b62d8c0360b27396c26050
Gerrit-Change-Number: 19537
Gerrit-PatchSet: 4
Gerrit-Owner: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Mar 2023 22:11:40 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11946: Add Thrift HTTP support for external frontend

Posted by "Aman Sinha (Code Review)" <ge...@cloudera.org>.
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/19537 )

Change subject: IMPALA-11946: Add Thrift HTTP support for external frontend
......................................................................


Patch Set 3: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19537/2/fe/src/test/java/org/apache/impala/customcluster/ExternalFrontendTest.java
File fe/src/test/java/org/apache/impala/customcluster/ExternalFrontendTest.java:

http://gerrit.cloudera.org:8080/#/c/19537/2/fe/src/test/java/org/apache/impala/customcluster/ExternalFrontendTest.java@22
PS2, Line 22: import org.apache.hive.service.rpc.thrift.TCloseSessionReq;
> Done
I thought that such imports would fail checkstyle but perhaps checkstyle is not enforced for the tests. The FE source code does not have wildcard imports. In any case you have made the change so all good !



-- 
To view, visit http://gerrit.cloudera.org:8080/19537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ad400b1df471e3d61b62d8c0360b27396c26050
Gerrit-Change-Number: 19537
Gerrit-PatchSet: 3
Gerrit-Owner: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Mar 2023 22:17:30 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11946: Add Thrift HTTP support for external frontend

Posted by "John Sherman (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19537

to look at the new patch set (#2).

Change subject: IMPALA-11946: Add Thrift HTTP support for external frontend
......................................................................

IMPALA-11946: Add Thrift HTTP support for external frontend

- Add enable_external_fe_http flag that defaults to false
  - When true the external frontend service (external_fe_port) will
  expect clients to use http transport.
  - When false the external frontend service will expect binary
  transport.

- Add tests for basic external frontend functionality
- Add test to ensure the non-external frontend services do not expose
  the ExecutePlannedStatement interface.

Change-Id: I2ad400b1df471e3d61b62d8c0360b27396c26050
---
M be/src/service/impala-server.cc
M fe/src/test/java/org/apache/impala/customcluster/CustomClusterRunner.java
A fe/src/test/java/org/apache/impala/customcluster/ExternalFrontendTest.java
3 files changed, 209 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/37/19537/2
-- 
To view, visit http://gerrit.cloudera.org:8080/19537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2ad400b1df471e3d61b62d8c0360b27396c26050
Gerrit-Change-Number: 19537
Gerrit-PatchSet: 2
Gerrit-Owner: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-11946: Add Thrift HTTP support for external frontend

Posted by "John Sherman (Code Review)" <ge...@cloudera.org>.
John Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/19537 )

Change subject: IMPALA-11946: Add Thrift HTTP support for external frontend
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/19537/2/fe/src/test/java/org/apache/impala/customcluster/ExternalFrontendTest.java
File fe/src/test/java/org/apache/impala/customcluster/ExternalFrontendTest.java:

http://gerrit.cloudera.org:8080/#/c/19537/2/fe/src/test/java/org/apache/impala/customcluster/ExternalFrontendTest.java@22
PS2, Line 22: import org.apache.hive.service.rpc.thrift.TCloseSessionReq;
> nit: I think the wildcard is not allowed for imports.
Done


http://gerrit.cloudera.org:8080/#/c/19537/2/fe/src/test/java/org/apache/impala/customcluster/ExternalFrontendTest.java@46
PS2, Line 46: rift.tr
> nit: maybe call this hs2BinaryPort to easily distinguish with the other one
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/19537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ad400b1df471e3d61b62d8c0360b27396c26050
Gerrit-Change-Number: 19537
Gerrit-PatchSet: 3
Gerrit-Owner: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Mar 2023 22:10:20 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11946: Add Thrift HTTP support for external frontend

Posted by "Aman Sinha (Code Review)" <ge...@cloudera.org>.
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/19537 )

Change subject: IMPALA-11946: Add Thrift HTTP support for external frontend
......................................................................


Patch Set 5: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/19537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ad400b1df471e3d61b62d8c0360b27396c26050
Gerrit-Change-Number: 19537
Gerrit-PatchSet: 5
Gerrit-Owner: John Sherman <jf...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: John Sherman <jf...@cloudera.com>
Gerrit-Comment-Date: Thu, 09 Mar 2023 02:02:07 +0000
Gerrit-HasComments: No