You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Robert Joseph Evans (JIRA)" <ji...@apache.org> on 2011/06/06 23:13:00 UTC

[jira] [Commented] (MAPREDUCE-2535) JobClient creates a RunningJob with null status and profile

    [ https://issues.apache.org/jira/browse/MAPREDUCE-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045112#comment-13045112 ] 

Robert Joseph Evans commented on MAPREDUCE-2535:
------------------------------------------------

     [exec] -1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     +1 tests included.  The patch appears to include 18 new or modified tests.
     [exec] 
     [exec]     -1 javadoc.  The javadoc tool appears to have generated 1 warning messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec] 
     [exec]     -1 Eclipse classpath. The patch causes the Eclipse classpath to differ from the contents of the lib directories.


The Eclipse issue and the Javadocs issues are bogus.  I didn't even change and of the source, just tests.

> JobClient creates a RunningJob with null status and profile
> -----------------------------------------------------------
>
>                 Key: MAPREDUCE-2535
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2535
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 0.20.204.0
>            Reporter: Robert Joseph Evans
>            Assignee: Robert Joseph Evans
>         Attachments: MR-2535-0.20.20X-V1.patch, MR-2535-failures-v1.patch
>
>
> Exception occurred because the job was retired and is removed from RetireJobCcahe and CompletedJobStatusStore. But, the
> JobClient creates a RunningJob with null status and profile, if getJob(JobID) is called again.
> So, Even-though not null check is there in the following user code, it did not help.
> 466             runningJob = jobClient.getJob(mapRedJobID);
> 467             if(runningJob != null) {
> JobClient.getJob() should return null if status is null.
> In trunk this is fixed by validating that the job status is not null every time it is updated, and also verifying that that the profile data is not null when created.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira