You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/08/04 10:43:13 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #1505: Reduce the preserved memory to save the space

xiaoxiang781216 opened a new pull request #1505:
URL: https://github.com/apache/incubator-nuttx/pull/1505


   ## Summary
   The memory consumption is reduced by 2KB.
   
   ## Impact
   
   ## Testing
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #1505: Reduce the preserved memory to save the space

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on pull request #1505:
URL: https://github.com/apache/incubator-nuttx/pull/1505#issuecomment-669711263


   minimal config with nsh:
   CONFIG_ARCH="sim"
   CONFIG_ARCH_BOARD="sim"
   CONFIG_ARCH_BOARD_SIM=y
   CONFIG_ARCH_CHIP="sim"
   CONFIG_ARCH_SIM=y
   CONFIG_DEBUG_SYMBOLS=y
   CONFIG_SIM_M32=y
   CONFIG_SYSTEM_NSH=y
   CONFIG_USER_ENTRYPOINT="nsh_main"
   I use 32bit sim, but the number should be similar for other arch/chip/board since the optimiation only focus on the preserved global memory which shouldn't have the significant difference if the config is same.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] jerpelea merged pull request #1505: Reduce the preserved memory to save the space

Posted by GitBox <gi...@apache.org>.
jerpelea merged pull request #1505:
URL: https://github.com/apache/incubator-nuttx/pull/1505


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] xiaoxiang781216 closed pull request #1505: Reduce the preserved memory to save the space

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 closed pull request #1505:
URL: https://github.com/apache/incubator-nuttx/pull/1505


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1505: Reduce the preserved memory to save the space

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1505:
URL: https://github.com/apache/incubator-nuttx/pull/1505#issuecomment-670674020


   @jerpelea could you merge this patch?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] jerpelea commented on pull request #1505: Reduce the preserved memory to save the space

Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #1505:
URL: https://github.com/apache/incubator-nuttx/pull/1505#issuecomment-668527358


   LGTM 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] yamt commented on pull request #1505: Reduce the preserved memory to save the space

Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #1505:
URL: https://github.com/apache/incubator-nuttx/pull/1505#issuecomment-669663425


   what kind of system the numbers in the commit message are measured for?
   eg. arch/board
   eg. number of tasks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1505: Reduce the preserved memory to save the space

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #1505:
URL: https://github.com/apache/incubator-nuttx/pull/1505#issuecomment-669711263


   minimal config with nsh:
   CONFIG_ARCH="sim"
   CONFIG_ARCH_BOARD="sim"
   CONFIG_ARCH_BOARD_SIM=y
   CONFIG_ARCH_CHIP="sim"
   CONFIG_ARCH_SIM=y
   CONFIG_DEBUG_SYMBOLS=y
   CONFIG_SIM_M32=y
   CONFIG_SYSTEM_NSH=y
   CONFIG_USER_ENTRYPOINT="nsh_main"
   I used 32bit sim, but the number should be similar for other arch since the optimiation focus on the preserved global memory.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org