You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/05/09 21:57:52 UTC

[GitHub] [spark] mridulm commented on pull request #36467: [SPARK-39063][CORE] Fix potential risk of JVM crash and `RocksDBIterator` resource leak

mridulm commented on PR #36467:
URL: https://github.com/apache/spark/pull/36467#issuecomment-1121625153

   I have not looked into this in great detail, but why not simply return a boolean from `notifyIteratorClosed` to indicate if the underlying db has been closed or not ?
   This can be used to determine if the iterator needs to be closed ? This is similar to what `closeIterator` does in RocksDb (for example)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org