[jira] [Commented] (CASSANDRA-16629) Refactor tests for NodeTool commands

["Benjamin Lerer (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-16629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17337395#comment-17337395 ] 

Benjamin Lerer commented on CASSANDRA-16629:
--------------------------------------------

Our test changes a lot from one version to the next and I do not believe that we should backport such refactoring. I also believe that we should probably commit them in trunk only once 4.0 has been branched to avoid any risk of introducing some flaky tests before we release 4.0 GA. [~mck] What is your opinion ?

Regarding the patch it looks good to me. We just need to rebase it after the branching and run CI.  

> Refactor tests for NodeTool commands
> ------------------------------------
>
>                 Key: CASSANDRA-16629
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16629
>             Project: Cassandra
>          Issue Type: Task
>          Components: Test/unit
>            Reporter: Alexey Zotov
>            Assignee: Alexey Zotov
>            Priority: Low
>             Fix For: 4.0.x
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> h3. Overview
> As a part of CASSANDRA-16404, I've been working on {{NodeTool}} commands for invalidation of the auth caches. While working on that, I've mentioned that the existing NodeTool unit tests are written in a different manner and reside in wrong packages. I've made the following changes to them:
> # moved them to the proper packages (that match original command class)
> # unified naming, formatting, imports
> # migrated from {{org.assertj}} to {{hamcrest}} for assertions (though it is not smth really required)
> # made a general cleanup
> PR: https://github.com/apache/cassandra/pull/982



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org