You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/20 07:15:09 UTC
[GitHub] [superset] ktmud opened a new issue #12614: [Explore] Open existing adhoc metric should not open the SAVED tab
ktmud opened a new issue #12614:
URL: https://github.com/apache/superset/issues/12614
@kgabryje @junlincc Found a bug on this one: opening a selected adhoc metric should open the SIMPLE or CUSTOM tab, but now it always opens the SAVED tab.
_Originally posted by @ktmud in https://github.com/apache/superset/issues/12582#issuecomment-763202521_
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on issue #12614: [Explore] Open existing adhoc metric should not open the SAVED tab
Posted by GitBox <gi...@apache.org>.
ktmud commented on issue #12614:
URL: https://github.com/apache/superset/issues/12614#issuecomment-763471148
Weird, I could not reproduce it any more, either.
Maybe it's because I confused it with re-opening the popover after switching tabs but not save. The popover always opens at the last active tab before closing (which I think is fine).
Sorry for the noise.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje edited a comment on issue #12614: [Explore] Open existing adhoc metric should not open the SAVED tab
Posted by GitBox <gi...@apache.org>.
kgabryje edited a comment on issue #12614:
URL: https://github.com/apache/superset/issues/12614#issuecomment-763459892
Could you share steps to reproduce? It seems to work correctly for me
https://user-images.githubusercontent.com/15073128/105153692-03b5a000-5b09-11eb-8c18-e864c06d93f1.mov
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on issue #12614: [Explore] Open existing adhoc metric should not open the SAVED tab
Posted by GitBox <gi...@apache.org>.
kgabryje commented on issue #12614:
URL: https://github.com/apache/superset/issues/12614#issuecomment-763459892
Could you share steps to reproduce? It seems to work correctly for me
https://user-images.githubusercontent.com/15073128/105153415-b2a5ac00-5b08-11eb-9abb-5480b1a97a40.mov
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on issue #12614: [Explore] Open existing adhoc metric should not open the SAVED tab
Posted by GitBox <gi...@apache.org>.
kgabryje commented on issue #12614:
URL: https://github.com/apache/superset/issues/12614#issuecomment-763471765
👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud closed issue #12614: [Explore] Open existing adhoc metric should not open the SAVED tab
Posted by GitBox <gi...@apache.org>.
ktmud closed issue #12614:
URL: https://github.com/apache/superset/issues/12614
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #12614: [Explore] Open existing adhoc metric should not open the SAVED tab
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #12614:
URL: https://github.com/apache/superset/issues/12614#issuecomment-763400968
Previous behavior & correct behavior is always open up the same tab that user created the metric in. My bad, did not catch it when I tested.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org