You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/08/10 18:12:00 UTC

[jira] [Commented] (TINKERPOP-1747) Streamline inheritance for gremlin-python GraphSON serializer classes

    [ https://issues.apache.org/jira/browse/TINKERPOP-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16122016#comment-16122016 ] 

ASF GitHub Bot commented on TINKERPOP-1747:
-------------------------------------------

Github user okram commented on the issue:

    https://github.com/apache/tinkerpop/pull/691
  
    I am not too hip to the Python code anymore, but I do know that adding the GraphSON3 support was a little "sketchy". Thus, if this is a Python-esque improvement upon my non-Python skills, then great.
    
    VOTE +1.


> Streamline inheritance for gremlin-python GraphSON serializer classes
> ---------------------------------------------------------------------
>
>                 Key: TINKERPOP-1747
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1747
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: language-variant
>    Affects Versions: 3.3.0
>            Reporter: David M. Brown
>             Fix For: 3.3.0
>
>
> This follows up on TINKERPOP-1427 by cleaning up the code used to create the various gremlin-python GraphSON serializers for GraphSON version 2 and 3. Several small changes can improve code style, reduce redundancy, and clarify when custom readers and writers can be passed to the serializer (generic serializer) vs. the GraphSON version specific serializers. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)